Fix formatting and localization of EMS task flash messages #1536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit mansam@2b7fa72 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
Failing CI, needs to be investigated / fixed. |
|
CI passed after restart, merging. |
|
Fine backport details: |
simaishi
pushed a commit
that referenced
this pull request
Jun 22, 2017
Fix formatting and localization of EMS task flash messages (cherry picked from commit 18fc31e) https://bugzilla.redhat.com/show_bug.cgi?id=1464151
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some ugly flash message formatting when executing EMS tasks. See below screenshots for a before and after.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1440109