Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when navigating from the Ansible repository to the playbook list #1532

Merged

Conversation

lgalis
Copy link
Contributor

@lgalis lgalis commented Jun 12, 2017

Add model name for Playbooks to MODEL_STRING

To reproduce:
Click on the playbook list in the Summary screen of an Ansible repository.

@miq-bot miq-bot added the wip label Jun 12, 2017
@lgalis lgalis changed the title [WIP] Error when navigating from the Ansible repository to the playbook list Error when navigating from the Ansible repository to the playbook list Jun 13, 2017
@miq-bot miq-bot removed the wip label Jun 13, 2017
@martinpovolny
Copy link
Member

martinpovolny commented Jun 13, 2017

@lgalis : Can you add a test for this, please?

Neither here nor in the commit message there's any clue about what error is being fixed here.

The best way to ensure that whatever was broken will stay working is a test ;-)

@lgalis lgalis changed the title Error when navigating from the Ansible repository to the playbook list [WIP]Error when navigating from the Ansible repository to the playbook list Jun 13, 2017
@miq-bot miq-bot added the wip label Jun 13, 2017
# Conflicts:
#	app/controllers/service_controller.rb
#	app/views/service/_svcs_show.html.haml
@lgalis lgalis force-pushed the miqreport_model_name_for_playbooks branch from 52a2e46 to 823a547 Compare June 28, 2017 22:08
@lgalis lgalis force-pushed the miqreport_model_name_for_playbooks branch from 823a547 to d87261b Compare June 29, 2017 18:36
@miq-bot
Copy link
Member

miq-bot commented Jun 29, 2017

Checked commits lgalis/manageiq-ui-classic@c97cb17~...d87261b with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 🏆

@lgalis lgalis changed the title [WIP]Error when navigating from the Ansible repository to the playbook list Error when navigating from the Ansible repository to the playbook list Jun 29, 2017
@miq-bot miq-bot removed the wip label Jun 29, 2017
@lgalis
Copy link
Contributor Author

lgalis commented Jul 5, 2017

@miq-bot add_label bug, GTL, fine/no

@miq-bot
Copy link
Member

miq-bot commented Jul 5, 2017

@lgalis Cannot apply the following label because they are not recognized: gtl

@h-kataria
Copy link
Contributor

looks good.

@h-kataria h-kataria added this to the Sprint 64 Ending Jul 10, 2017 milestone Jul 5, 2017
@h-kataria h-kataria merged commit 937e70b into ManageIQ:master Jul 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants