Set default port for lenovo provider form to 443 #1531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzazrivec
suggested changes
Jun 13, 2017
| @@ -386,6 +386,8 @@ ManageIQ.angular.app.controller('emsCommonFormController', ['$http', '$scope', ' | |||
| $scope.emsCommonModel.default_api_port = "443"; | |||
| $scope.emsCommonModel.event_stream_selection = "none"; | |||
| $scope.emsCommonModel.amqp_security_protocol = 'non-ssl'; | |||
| }else if ($scope.emsCommonModel.emstype === 'lenovo_ph_infra') { | |||
There was a problem hiding this comment.
Missing space before else
|
Checked commits https://github.com/lenovo/manageiq-ui-classic/compare/ac4fbed22e9a79af977012371e080c4a072ad2b3~...4be4927051432d0c8cf88acb1193fbd15ac561ff with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
I updated the PR based on your review @mzazrivec. Thanks. |
mzazrivec
approved these changes
Jun 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-fills the provider form for adding a Lenovo provider to use the API port 443. See screenshot. User may continue with the default or if they have configured Xclarity with a custom port they may modify.
@miq-bot add_label compute/physical infrastructure, enhancement, graphics