Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tenant admin should not be able to create groups in other tenants. #151

Merged
merged 1 commit into from
Jan 17, 2017
Merged

Tenant admin should not be able to create groups in other tenants. #151

merged 1 commit into from
Jan 17, 2017

Conversation

martinpovolny
Copy link
Member

#134

This is only a part of the fix. The 2nd part needs fixing on the
manageiq core side: ManageIQ/manageiq#13483

@martinpovolny martinpovolny mentioned this pull request Jan 13, 2017
Merged
@martinpovolny martinpovolny changed the title Tenant admin should not be able to create groups in other tenants. [WIP] Tenant admin should not be able to create groups in other tenants. Jan 13, 2017
@martinpovolny martinpovolny removed the wip label Jan 13, 2017
@martinpovolny martinpovolny changed the title [WIP] Tenant admin should not be able to create groups in other tenants. Tenant admin should not be able to create groups in other tenants. Jan 13, 2017
@martinpovolny martinpovolny changed the title Tenant admin should not be able to create groups in other tenants. [WIP] Tenant admin should not be able to create groups in other tenants. Jan 13, 2017
@martinpovolny martinpovolny changed the title [WIP] Tenant admin should not be able to create groups in other tenants. Tenant admin should not be able to create groups in other tenants. Jan 13, 2017
@martinpovolny martinpovolny removed the wip label Jan 13, 2017
@martinpovolny
Tenant admin should not be able to create groups in other tenants.
e46ed97 
ManageIQ#134

This is only a part of the fix. The 2nd part needs fixing on the
manageiq core side.
@miq-bot
Copy link
Member

miq-bot commented Jan 17, 2017

Checked commit martinpovolny@e46ed97 with ruby 2.2.6, rubocop 0.46.0, and haml-lint 0.19.0
1 file checked, 0 offenses detected
Everything looks good. 🍰

@mzazrivec mzazrivec self-assigned this Jan 17, 2017
@mzazrivec mzazrivec added this to the Sprint 53 Ending Jan 30, 2017 milestone Jan 17, 2017
@mzazrivec mzazrivec merged commit 637a45d into ManageIQ:master Jan 17, 2017
@martinpovolny
Copy link
Member Author

@simaishi : there's a bug in this solution. I will fix it and we would need to cherry-pick it together with the fix.

@martinpovolny martinpovolny mentioned this pull request Jan 20, 2017
Merged
@martinpovolny
Copy link
Member Author

@simaishi : created a BZ https://bugzilla.redhat.com/show_bug.cgi?id=1415100

@martinpovolny
Copy link
Member Author

to be cherry-picked together with #203

@simaishi
Copy link
Contributor

Euwe backport (to manageiq repo) details:

$ git log -1
commit 9be9b26d0351aa09cef3d9dadc9a9fcbad32d957
Author: Milan Zázrivec <[email protected]>
Date:   Tue Jan 17 17:28:02 2017 +0100

    Merge pull request #151 from martinpovolny/tenant_escape
    
    Tenant admin should not be able to create groups in other tenants.
    (cherry picked from commit 637a45d6312827c4a2f15048361d86ec5f2198ac)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1415217

@martinpovolny martinpovolny deleted the tenant_escape branch March 8, 2017 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mzazrivec mzazrivec

Labels
bug euwe/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@martinpovolny @miq-bot @simaishi @mzazrivec