Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BZ#1457491 - fix middleware providers broken links in timeline events #1492

Merged
merged 1 commit into from
Jun 13, 2017

Conversation

abonas
Copy link
Member

@abonas abonas commented Jun 6, 2017

before the fix, the link contained /show/ which is not working correctly

after the fix:
provider_link

@miq-bot add_label bug, middleware, events

https://bugzilla.redhat.com/show_bug.cgi?id=1457491

@miq-bot
Copy link
Member

miq-bot commented Jun 6, 2017

@abonas Cannot apply the following label because they are not recognized: events

@abonas abonas force-pushed the fixTimelineBrokenLink branch from 189aa63 to 2121c1f Compare June 6, 2017 14:51
@abonas abonas changed the title BZ 1457491 - fix middleware providers broken links in timeline events BZ#1457491 - fix middleware providers broken links in timeline events Jun 6, 2017
@miq-bot
Copy link
Member

miq-bot commented Jun 6, 2017

Checked commit abonas@2121c1f with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@abonas
Copy link
Member Author

abonas commented Jun 6, 2017

@miq-bot assign @martinpovolny
cc @Jiri-Kremser please review

@jkremser
Copy link
Member

jkremser commented Jun 6, 2017

what about this place ?

It looks like a general method for other middleware entities, but I am not aware of any other entity that can have events associated with it.

@abonas
Copy link
Member Author

abonas commented Jun 6, 2017

what about this place ?

It looks like a general method for other middleware entities, but I am not aware of any other entity that can have events associated with it.

the show method is required for the non provider entities, I checked and it does not work without it.
it is for the link to show which related entity it happened on (see screenshot above for example where it says LocalDMR)

@jkremser
Copy link
Member

jkremser commented Jun 6, 2017

lgtm, the failure in the javascript specs does not seem to be related

@abonas
Copy link
Member Author

abonas commented Jun 12, 2017

ping?

@abonas
Copy link
Member Author

abonas commented Jun 12, 2017

@martinpovolny merge please?
cc @mtho11

@martinpovolny martinpovolny added this to the Sprint 63 Ending Jun 19, 2017 milestone Jun 13, 2017
@martinpovolny martinpovolny merged commit 45f034f into ManageIQ:master Jun 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants