Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spec to use correct status of miq_task (CI failure) #1481

Merged

Conversation

lpichler
Copy link
Contributor

@lpichler lpichler commented Jun 2, 2017

Node icon have not to be an error icon,
we need to add report to miq_report_result,
for now I am adding just empty report.

caused by ManageIQ/manageiq@fa4ebc6

https://travis-ci.org/ManageIQ/manageiq-ui-classic/jobs/238705812#L1267

cc @yrudman
@miq-bot assign @mzazrivec

Node icon have not to be error icon,
we need to add report to miq_report_result,
for now I am adding just empty report.
@miq-bot
Copy link
Member

miq-bot commented Jun 2, 2017

Checked commit lpichler@622b95a with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🍰

@yrudman
Copy link
Contributor

yrudman commented Jun 2, 2017

@lpichler my bad, I missed UI spec. Thank you Libor for fixing

@lpichler lpichler closed this Jun 5, 2017
@lpichler lpichler reopened this Jun 5, 2017
@martinpovolny martinpovolny merged commit c321505 into ManageIQ:master Jun 5, 2017
@martinpovolny martinpovolny added this to the Sprint 62 Ending Jun 5, 2017 milestone Jun 5, 2017
simaishi pushed a commit that referenced this pull request Jun 12, 2017
Fix spec to use correct status of miq_task (CI failure)
(cherry picked from commit c321505)

https://bugzilla.redhat.com/show_bug.cgi?id=1460394
@simaishi
Copy link
Contributor

ManageIQ/manageiq#15134 which caused the Travis failure is backported to Fine.

Fine backport details:

$ git log -1
commit 8e42ae102ba1cfdae409a9d67d5d0db8dc19829f
Author: Martin Povolny <[email protected]>
Date:   Mon Jun 5 10:31:22 2017 +0200

    Merge pull request #1481 from lpichler/fix_ci_failure_error_status
    
    Fix spec to use correct status of miq_task (CI failure)
    (cherry picked from commit c321505512372a033e637a6029d4e628dce4c233)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1460394

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants