Fix Physical Server link in Physical Infra Summary page #1479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label fine/no,bug,compute/physical infrastructure |
No need to repeat the `display_methods` array in the haml
AparnaKarve
force-pushed
the
fix_phy_server_relationship
branch
from
743f47b to
14c5662
Compare
|
Checked commits AparnaKarve/manageiq-ui-classic@ee3bada~...82c1c8e with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
physical_serversentry had to be added to the whitelist indisplay_methodsin order to make this linkhttp://localhost:3000/ems_physical_infra/1?display=physical_serverswork.The PR also contains a DRY refactor in
app/views/shared/views/ems_common/_show.html.hamlwhere instead of repeating the entire list indisplay_methods, we would be simply using the existing list.Also fixed the listnav to display the Physical Server count.
Before:
After:
