Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed prompt for log collection by reorganizing button inheritance #1413

Merged
merged 1 commit into from
May 24, 2017

Conversation

skateman
Copy link
Member

@skateman skateman commented May 23, 2017

@miq-bot miq-bot added the bug label May 23, 2017
@skateman skateman force-pushed the log-collection-fix branch 2 times, most recently from c708915 to 45ba57a Compare May 23, 2017 11:39
@skateman skateman force-pushed the log-collection-fix branch from 45ba57a to f1a6023 Compare May 23, 2017 16:39
@miq-bot
Copy link
Member

miq-bot commented May 23, 2017

Checked commit skateman@f1a6023 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
7 files checked, 2 offenses detected

app/helpers/application_helper/toolbar/diagnostics_server_center.rb

app/helpers/application_helper/toolbar/diagnostics_zone_center.rb

@mzazrivec mzazrivec added this to the Sprint 62 Ending Jun 5, 2017 milestone May 24, 2017
@mzazrivec mzazrivec self-assigned this May 24, 2017
@mzazrivec mzazrivec merged commit 5288862 into ManageIQ:master May 24, 2017
@skateman skateman deleted the log-collection-fix branch May 24, 2017 08:34
simaishi pushed a commit that referenced this pull request Jun 8, 2017
Fixed prompt for log collection by reorganizing button inheritance
(cherry picked from commit 5288862)

https://bugzilla.redhat.com/show_bug.cgi?id=1460033
@simaishi
Copy link
Contributor

simaishi commented Jun 8, 2017

Fine backport details:

$ git log -1
commit 03595170593ff63aa83fb148edae5618e5fcdfb7
Author: Milan Zázrivec <[email protected]>
Date:   Wed May 24 10:33:19 2017 +0200

    Merge pull request #1413 from skateman/log-collection-fix
    
    Fixed prompt for log collection by reorganizing button inheritance
    (cherry picked from commit 528886265a82b453fe6e0c92421dbbdb0f40fdf4)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1460033

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants