Add container limits to container summary page #1401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM pending travis 👍 |
|
|
||
| def collect_limit_items | ||
| rows = [] | ||
| @record.container_limit_items.each do |item| |
There was a problem hiding this comment.
use collect instead of using temporaty variable rows, please
|
Travis failure seems related. Please, take a look. |
zeari
force-pushed
the
container_definition_limits
branch
from
b7f28b8 to
8ae4d0b
Compare
|
@zeari : removing the "pending" label, restarting travis... |
zeari
force-pushed
the
container_definition_limits
branch
from
8ae4d0b to
f40111d
Compare
|
Checked commit zeari@f40111d with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 app/helpers/container_helper/textual_summary.rb
|
|
@martinpovolny I think this is ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on ManageIQ/manageiq#15180(merged)@zakiva @nimrodshn Please review
cc @simon3z