Save new dialog value & other UI issues fixed #1330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed saving of new dialog name, reset 'Hosts' field when playbook is selected on Retirement tab during edit and fixed issues related to initialization of Escalate Privilege switch https://bugzilla.redhat.com/show_bug.cgi?id=1448228
|
Checked commit h-kataria@4f29b13 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
Looks good. Tested in the ui for both the uninitialized escalation flag as well as the Host field in the retirement tab. |
simaishi
pushed a commit
that referenced
this pull request
Jun 8, 2017
Save new dialog value & other UI issues fixed (cherry picked from commit 62c2b33) https://bugzilla.redhat.com/show_bug.cgi?id=1459962
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed saving of new dialog name, reset 'Hosts' field when playbook is selected on Retirement tab during edit and fixed issues related to initialization of Escalate Privilege switch
https://bugzilla.redhat.com/show_bug.cgi?id=1448228
@lgalis @bzwei please test.
Please see steps to recreate issues with Escalate Privilege switch & hosts field below:
To see Escalate Privilege switch in a weird state:
Hosts field: Save a catalog item without a playbook on retirement tab. Go to edit the same catalog item, value of Hosts text box is empty, after selecting Playbook it should initialize Hosts text field.