Added to_i to port & end_port attributes #1318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added to_i to 'port' & 'end_port' attributes, to prevent comparison of Array with Array error when there is no value provided for port or end_port fields. https://bugzilla.redhat.com/show_bug.cgi?id=1449053
|
Checked commit h-kataria@f2d066f with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 spec/helpers/security_group_helper/textual_summary_spec.rb
|
simaishi
pushed a commit
that referenced
this pull request
May 9, 2017
Added to_i to port & end_port attributes (cherry picked from commit 80aee06) https://bugzilla.redhat.com/show_bug.cgi?id=1449365
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added to_i to 'port' & 'end_port' attributes, to prevent comparison of Array with Array error when there is no value provided for port or end_port fields.
https://bugzilla.redhat.com/show_bug.cgi?id=1449053
@dclarizio please review.