Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display summary tags for the ansible playbook services #1297

Merged
merged 2 commits into from
May 9, 2017
Merged

Display summary tags for the ansible playbook services #1297

merged 2 commits into from
May 9, 2017

Conversation

lgalis
Copy link
Contributor

@lgalis lgalis commented May 5, 2017 •
edited
Loading

Display tags for the ansible playbook services in the summary screen.

https://bugzilla.redhat.com/show_bug.cgi?id=1448291

screenshot from 2017-05-05 17-11-24

@miq-bot miq-bot added the wip label May 5, 2017
@lgalis lgalis force-pushed the ansible_playbook_summary_service_summary_display_tags branch 2 times, most recently from a382af2 to fbdaac2 Compare May 8, 2017 18:08
@lgalis lgalis force-pushed the ansible_playbook_summary_service_summary_display_tags branch 3 times, most recently from 61d7582 to 3334119 Compare May 8, 2017 19:32
@lgalis lgalis force-pushed the ansible_playbook_summary_service_summary_display_tags branch from 3334119 to e085b72 Compare May 8, 2017 19:37
@miq-bot
Copy link
Member

miq-bot commented May 8, 2017

Checked commits lgalis/manageiq-ui-classic@2680f53~...e085b72 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 🍰

@lgalis
Copy link
Contributor Author

lgalis commented May 8, 2017

@miq-bot assign @h-kataria

@lgalis lgalis closed this May 9, 2017
@lgalis lgalis reopened this May 9, 2017
@lgalis lgalis changed the title [WIP] Display summary tags for the ansible playbook services Display summary tags for the ansible playbook services May 9, 2017
@lgalis
Copy link
Contributor Author

lgalis commented May 9, 2017

@h-kataria - please review

@miq-bot miq-bot removed the wip label May 9, 2017
@h-kataria
Copy link
Contributor

looks good

@h-kataria h-kataria added this to the Sprint 61 Ending May 22, 2017 milestone May 9, 2017
@h-kataria h-kataria merged commit 9c83494 into ManageIQ:master May 9, 2017
simaishi pushed a commit that referenced this pull request Jun 8, 2017
@h-kataria @simaishi
Merge pull request #1297 from lgalis/ansible_playbook_summary_service…
91f0372 
…_summary_display_tags

Display summary tags for the ansible playbook services
(cherry picked from commit 9c83494)

https://bugzilla.redhat.com/show_bug.cgi?id=1459902
@simaishi
Copy link
Contributor

simaishi commented Jun 8, 2017

Fine backport details:

$ git log -1
commit 91f037221fdc776a231c8fd50a24d794bce917c9
Author: Harpreet Kataria <[email protected]>
Date:   Tue May 9 15:29:20 2017 -0400

    Merge pull request #1297 from lgalis/ansible_playbook_summary_service_summary_display_tags
    
    Display summary tags for the ansible playbook services
    (cherry picked from commit 9c8349401984d9852bfa30d5593772772b62db98)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1459902

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@h-kataria h-kataria

Labels
bug fine/backported services
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lgalis @miq-bot @h-kataria @simaishi