Add groups for PhysicalServer#show page #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_labels graphics, textual summaries |
|
Checked commit gabrielsvinha@4055129 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@miq-bot add_label compute/physical infrastructure |
|
The travis failure seems related. |
|
@martinpovolny I believe it's failing due to the lack of changes made in #1295 It shows |
Merged
|
@gabrielsvinha Ideally #1295 should have included what you currently have in this PR. |
|
Closing to run travis tests. |
|
@dclarizio Spec failures are unrelated, so we can merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request add the groups in physical server controller to show in Physical Server summary page.
Adds the following groups:
Depends on: #1295 #1281