Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify VM power status is not Nil when displaying Cloud Topology #1278

Merged
merged 1 commit into from
May 4, 2017
Merged

Verify VM power status is not Nil when displaying Cloud Topology #1278

merged 1 commit into from
May 4, 2017

Conversation

GregP
Copy link
Contributor

@GregP GregP commented May 4, 2017

https://bugzilla.redhat.com/show_bug.cgi?id=1447795

Screen shots before and after code fix:

bz1447795_compute clouds topolgy run time error dialog in ui

Topology display after code fix:
bz1447795_compute clouds topology after code fix

@GregP
Copy link
Contributor Author

GregP commented May 4, 2017

@h-kataria Ready for review.

@miq-bot
Copy link
Member

miq-bot commented May 4, 2017

Checked commit GregP@5eb8a52 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@GregP GregP closed this May 4, 2017
@GregP GregP reopened this May 4, 2017
@h-kataria
Copy link
Contributor

LGTM

@h-kataria h-kataria self-assigned this May 4, 2017
@h-kataria h-kataria added this to the Sprint 60 Ending May 8, 2017 milestone May 4, 2017
@h-kataria h-kataria merged commit c34bcd6 into ManageIQ:master May 4, 2017
simaishi pushed a commit that referenced this pull request May 4, 2017
@h-kataria @simaishi
Merge pull request #1278 from GregP/cloud_topology_power_status_nil
5a9c09c 
Verify VM power status is not Nil when displaying Cloud Topology
(cherry picked from commit c34bcd6)

https://bugzilla.redhat.com/show_bug.cgi?id=1448207
@simaishi
Copy link
Contributor

simaishi commented May 4, 2017

Fine backport details:

$ git log -1
commit 5a9c09c5e529aec87e0b4be7663b4023a8bbbefe
Author: Harpreet Kataria <[email protected]>
Date:   Thu May 4 14:09:12 2017 -0400

    Merge pull request #1278 from GregP/cloud_topology_power_status_nil
    
    Verify VM power status is not Nil when displaying Cloud Topology
    (cherry picked from commit c34bcd6070a85a89a3b5a7b407d016a71a54d1ab)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1448207

@jzigmund jzigmund mentioned this pull request May 5, 2017
Closed
@himdel himdel mentioned this pull request May 5, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@h-kataria h-kataria

Labels
blocker bug compute/cloud fine/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GregP @miq-bot @h-kataria @simaishi