Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate dom id compare advsearch #1269

Merged
merged 2 commits into from
May 4, 2017
Merged

Duplicate dom id compare advsearch #1269

merged 2 commits into from
May 4, 2017

Conversation

martinpovolny
Copy link
Member

ping @skateman

skateman
skateman approved these changes May 4, 2017
View reviewed changes
Copy link
Member

@skateman skateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miq-bot
Copy link
Member

miq-bot commented May 4, 2017

Checked commits martinpovolny/manageiq-ui-classic@7cdbedb~...6b8cd8f with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 🏆

@dclarizio dclarizio assigned dclarizio and unassigned mzazrivec May 4, 2017
@dclarizio dclarizio merged commit db55395 into ManageIQ:master May 4, 2017
@dclarizio dclarizio added this to the Sprint 60 Ending May 8, 2017 milestone May 4, 2017
@martinpovolny martinpovolny deleted the duplicate_dom_id_compare_advsearch branch November 28, 2017 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skateman skateman skateman approved these changes

Assignees

@dclarizio dclarizio

Labels
bug compute/infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@martinpovolny @miq-bot @skateman @dclarizio @mzazrivec