Check :sort_by: :none to keep the field values in the order that they are inserted in the file. #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmcculloug
reviewed
May 3, 2017
| @@ -258,6 +258,8 @@ | |||
| - opts = multiple ? [] : [["<#{_('None')}>", nil]] | |||
| - if field_hash[:data_type] == :integer | |||
| - opts += Array(field_hash[:values].invert).sort_by(&:last) | |||
| - elsif field_hash[:sort_by] == :none | |||
There was a problem hiding this comment.
@lfu Wouldn't you want this to be the first check? Otherwise and integer field could never support a sort_by value of :none.
lfu
force-pushed
the
dialog_field_sort_none_1389010
branch
from
4f5bd47 to
d28172e
Compare
|
Checked commit lfu@d28172e with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 app/views/miq_request/_prov_field.html.haml
|
gmcculloug
approved these changes
May 3, 2017
|
@miq-bot add_label bug, euwe/yes, fine/yes |
h-kataria
approved these changes
May 3, 2017
|
test failure is unrelated to changes in this PR. |
|
Euwe backport (to manageiq repo) details: |
simaishi
pushed a commit
that referenced
this pull request
Jun 5, 2017
Check :sort_by: :none to keep the field values in the order that they are inserted in the file. (cherry picked from commit 662b026) https://bugzilla.redhat.com/show_bug.cgi?id=1458447
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #manageiq/14981.
https://bugzilla.redhat.com/show_bug.cgi?id=1389010