Use properties in the model when retrieving the ansible repo for editing

[lgalis]

Only copy the properties in the model when retrieving the Ansible repository info for editing

https://bugzilla.redhat.com/show_bug.cgi?id=1445995

• fixes the extra attributes sent to the tower gem for repository edit

/cc @jameswnl
/cc @ZitaNemeckova

[lgalis]

@miq-bot add_label bug, fine/yes, euwe/no

[lgalis]

@miq-bot add_label blocker

[lgalis]

@h-kataria or @dclarizio - please review

[himdel]

@lgalis This is moving us in completely the opposite direction.. In general we should be able to save everything we got from the server.

So.. what is this about? What specifically are the fields that appear in the model and should not be there when saving?

EDIT: if this is about managerResource, then I guess you should just be doing delete vm.repositoryModel.managerResource in saveClicked.

[lgalis]

@himdel - no - this is about href and actions that we are saving in the angular model ( and then sending on update )when getting the data from the API
This PR is to read only what is in the angular model - as these are the attributes we will be updating,
The alternative is to remove what we know is not part of the actual data - like the href and actions.

[himdel]

actions and href

Wow, that may need some more discussion with the API people, seems like those should never be mixed together with the record data.. but for now, yeah, I still prefer the blacklist approach over a whitelist, unless it's a problem somehow..

[himdel]

.. ok, thinking about this some more, this exact same problem happens for every single API endpoint.

So.. I guess we should just drop this fix, and fix it on the API side, because otherwise you need to fix every single API user in the UI to delete those 2 attributes.

@jameswnl Laura mentioned you have a fix for that on the API side? Is there a PR please?

(The issue that actions and href should be ignored from any POST & PUT & PATCH to the API)

[lgalis]

@himdel - not for the API, for the client - ansible/ansible_tower_client_ruby#93
I will discuss with API team

[jameswnl]

Thanks Laura, you are fast.

Yes, it's on the client gem.

[himdel]

Oh, but then we definitely need an API fix. Or, we could filter it in the common code in miq_api.js for now, but .. I'd much rather see this fixed on the API side...

[lgalis]

An API fix is not required nor would it be enough here, There are many fields that we do not need to retrieve.
I will be modifying the PR to only request from the API the fields we need.
This approach can be discussed with our team and the API team and modified as needed but not in the scope of this PR.

[dclarizio]

@lgalis looks like an easy cc fix

@himdel

I will be modifying the PR to only request from the API the fields we need.

@lgalis and I discussed fetching only the fields needed, similar to what we've seen in the SUI, so hopefully that approach looks good to you. Please re-review as we're hoping to get this in for the blocker BZ.

[miq-bot]

Checked commits lgalis/manageiq-ui-classic@5c11830~...671fe00 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

[himdel]

Thanks, well, I definitely like the delete approach more, but sending the list of attributes is just another whitelist.. but never mind, no real objections now :).

[simaishi]

Fine backport details:

$ git log -1
commit c8afdc762d7dda4e0cf4f708c07e985f7c08c848
Author: Dan Clarizio <[email protected]>
Date:   Thu May 4 06:40:12 2017 -0700

    Merge pull request #1230 from lgalis/use_only_repository_properties_in_model_on_edit
    
    Use properties in the model when retrieving the ansible repo for editing
    (cherry picked from commit 5bc21d4ea0e07ed4e06b0d7bdad14fb8f64606db)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1448098