Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RBAC for requesters in MiqRequest #1214

Merged
merged 1 commit into from
May 10, 2017
Merged

Add RBAC for requesters in MiqRequest #1214

merged 1 commit into from
May 10, 2017

Conversation

lpichler
Copy link
Contributor

@lpichler lpichler commented May 2, 2017

Services -> Requests -> select box requesters

Test scenario

My Company ->
  ServiceMaster ->
    ServiceA
    ServiceB

ServiceB user was able to see ServiceA's and another requester in the
select box and he should see only his requests or of his children.

before
screen shot 2017-05-02 at 13 19 37

after
screen shot 2017-05-02 at 13 25 45

Links

https://bugzilla.redhat.com/show_bug.cgi?id=1375722

cc @gtanzillo

@miq-bot assign @martinpovolny

@lpichler
Add RBAC for requesters in MiqRequest
f20d70c 
Services -> Requests -> select box requesters

Scenario

My Company ->
  ServiceMaster ->
    ServiceA
    ServiceB
-------------------

ServiceB user was able to see ServiceA's and other requester in the
select box
@miq-bot
Copy link
Member

miq-bot commented May 2, 2017

Checked commit lpichler@f20d70c with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

@martinpovolny martinpovolny added this to the Sprint 60 Ending May 8, 2017 milestone May 2, 2017
@martinpovolny
Copy link
Member

@simaishi : this is also relevant for the RBAC bz and should go to Fine.

gtanzillo
gtanzillo approved these changes May 10, 2017
View reviewed changes
Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@mzazrivec mzazrivec modified the milestones: Sprint 61 Ending May 22, 2017, Sprint 60 Ending May 8, 2017 May 10, 2017
@mzazrivec mzazrivec merged commit 15e285a into ManageIQ:master May 10, 2017
@lpichler lpichler deleted the rbac_for_selection_of_requesters_for_miq_requests branch May 10, 2017 10:11
simaishi pushed a commit that referenced this pull request Jun 8, 2017
@mzazrivec @simaishi
Merge pull request #1214 from lpichler/rbac_for_selection_of_requeste…
e6c1fe7 
…rs_for_miq_requests

Add RBAC for requesters in MiqRequest
(cherry picked from commit 15e285a)
@simaishi
Copy link
Contributor

simaishi commented Jun 8, 2017

Fine backport details:

$ git log -1
commit e6c1fe7dc5c4fc9e5cc160c6d947ae1b1875fb20
Author: Milan Zázrivec <[email protected]>
Date:   Wed May 10 12:11:20 2017 +0200

    Merge pull request #1214 from lpichler/rbac_for_selection_of_requesters_for_miq_requests
    
    Add RBAC for requesters in MiqRequest
    (cherry picked from commit 15e285aa12578e6a9ce19ff59b697669c0f53abd)

@martinpovolny martinpovolny mentioned this pull request Jun 12, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtanzillo gtanzillo gtanzillo approved these changes

Assignees

@martinpovolny martinpovolny

Labels
bug fine/backported rbac
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lpichler @miq-bot @martinpovolny @simaishi @gtanzillo @mzazrivec