Fix tags format

[yaacov]

Description

Description of problem:
Smart management tags are not show on current format on the following views:

1. Routes
2. Container Services
3. Nodes
4. Container Templates
5. Image Registries

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1439776

Screenshoots

[yaacov]

@miq-bot add_label compute/containers, bug

@simon3z @zeari @dkorn @moolitayer @himdel please review

[simon3z]

@yaacov when/where this regression was introduced?

[moolitayer]

cc @martinpovolny

[yaacov]

@yaacov when/where this regression was introduced?

@simon3z
This are leftovers from a big re-factor 3 months ago:
#274

[simon3z]

LGTM 👍
@miq-bot assign himdel
cc @martinpovolny @h-kataria @dclarizio

[simon3z]

@miq-bot add_label fine/yes

[himdel]

@yaacov I think you've missed a few...

app/helpers/container_helper/textual_summary.rb
app/helpers/container_project_helper/textual_summary.rb
app/helpers/persistent_volume_helper/textual_summary.rb
app/helpers/container_image_helper/textual_summary.rb
app/helpers/container_group_helper/textual_summary.rb
app/helpers/container_build_helper/textual_summary.rb
app/helpers/container_replicator_helper/textual_summary.rb

(all of those have a textual_group_smart_management that does the items.collect thing)

Otherwise, LGTM 👍

[yaacov]

@yaacov I think you've missed a few...

Woooo 👍 , they have a different bug :-) they use TextualTags and not TextualGroup like the ones in the BZ. Here we get "No My Company Tags have been assigned" message , when you do have one :-(

Fixing it now :-)

[EDIT]
No, it was me not setting the tags correctly .... , they just work correctly because they use TextualTags and not TextualGroup

[yaacov]

@himdel 👍 added the missing files [ they did not show the bug because they where using TextualTags and not TextualGroup ] but the code is nicer now :-)

[dclarizio]

@yaacov

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1444636

This BZ is closed, can you change to the one referenced as the dup? Thx, Dan

[yaacov]

This BZ is closed, can you change to the one referenced as the dup? Thx, Dan

@dclarizio 👍 changed in description to https://bugzilla.redhat.com/show_bug.cgi?id=1439776

those have a textual_group_smart_management that does the items.collect thing

@moolitayer, @himdel , looking at it again, the problem was not the items.collect but the TextualGroup, I think we need the call for send("textual_#{m}") to hide some tags that user should not see @dkorn ?

Updated screenshots in description, using new code, it fixes the bug, but does not change the logic of the function.

[himdel]

@yaacov nope, it was better as you had it before .. everywhere else uses just TextualTags.new(_("Smart Management"), %i(tags)) or sometimes TextualTags.new(_("Smart Management"), %i(zone tags)).

The code is semantically equivalent (see expand_textual_summary in textual_summary_helper.rb) - when it gets a symbol, it essentially does the same thing (except for a few additional fixups which is why we prefer the symbol version).

[yaacov]

@himdel 👍 done

[miq-bot]

Checked commit yaacov@b1c3064 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
12 files checked, 0 offenses detected
Everything looks fine. 🍪

[himdel]

Thanks, LGTM, waiting for travis.. :)

[chrispy1]

@miq-bot add_label blocker

[simaishi]

Fine backport details:

$ git log -1
commit 7e8cf4b0bb7d34372722c559416fbcafd41659d2
Author: Martin Povolny <[email protected]>
Date:   Thu Apr 27 20:09:43 2017 +0200

    Merge pull request #1180 from yaacov/tags-correct-format
    
    Fix tags format
    (cherry picked from commit cadbf73337ecfcef2c4a6f2625795480626e7d4e)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1446775