Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ownership link for infrastructure templates #1174

Merged
merged 2 commits into from
Apr 27, 2017
Merged

Fix ownership link for infrastructure templates #1174

merged 2 commits into from
Apr 27, 2017

Conversation

lgalis
Copy link
Contributor

@lgalis lgalis commented Apr 27, 2017

Fix ownership link for infrastructure templates

https://bugzilla.redhat.com/show_bug.cgi?id=1445244

@miq-bot miq-bot added the wip label Apr 27, 2017
@lgalis lgalis force-pushed the fix_ownership_link_for_templates branch from ae4b283 to b7a654b Compare April 27, 2017 15:46
@miq-bot
Copy link
Member

miq-bot commented Apr 27, 2017

Checked commits lgalis/manageiq-ui-classic@928955a~...b7a654b with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. ⭐

@lgalis
Copy link
Contributor Author

lgalis commented Apr 27, 2017

@miq-bot add_label bug, fine/yes, euwe/yes

@lgalis lgalis changed the title [WIP] Fix ownership link for infrastructure templates Fix ownership link for infrastructure templates Apr 27, 2017
@lgalis
Copy link
Contributor Author

lgalis commented Apr 27, 2017

@dclarizio - please review

@miq-bot miq-bot removed the wip label Apr 27, 2017
@dclarizio dclarizio self-assigned this Apr 27, 2017
@dclarizio dclarizio merged commit 6f84921 into ManageIQ:master Apr 27, 2017
@dclarizio dclarizio added this to the Sprint 60 Ending May 8, 2017 milestone Apr 27, 2017
@lgalis lgalis deleted the fix_ownership_link_for_templates branch April 27, 2017 17:33
@chrispy1
Copy link

chrispy1 commented May 4, 2017

@miq-bot add_label blocker

@miq-bot miq-bot added the blocker label May 4, 2017
simaishi pushed a commit that referenced this pull request May 4, 2017
@simaishi
Merge pull request #1174 from lgalis/fix_ownership_link_for_templates
2ea5564 
Fix ownership link for infrastructure templates
(cherry picked from commit 6f84921)

https://bugzilla.redhat.com/show_bug.cgi?id=1448071
@simaishi
Copy link
Contributor

simaishi commented May 4, 2017

Fine backport details:

$ git log -1
commit 2ea55642a3fa8e713dd14143e346d66c5fbd5b50
Author: Dan Clarizio <[email protected]>
Date:   Thu Apr 27 09:54:10 2017 -0700

    Merge pull request #1174 from lgalis/fix_ownership_link_for_templates
    
    Fix ownership link for infrastructure templates
    (cherry picked from commit 6f849211ce3468204b728ca5123d7529c7e332e7)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1448071

@simaishi
Copy link
Contributor

Euwe backport details:

$ git log -1
commit b8c9a7cb3e09292a35472e9ebbe2f8eec2659d2a
Author: Dan Clarizio <[email protected]>
Date:   Thu Apr 27 09:54:10 2017 -0700

    Merge pull request #1174 from lgalis/fix_ownership_link_for_templates
    
    Fix ownership link for infrastructure templates
    (cherry picked from commit 6f849211ce3468204b728ca5123d7529c7e332e7)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1448073

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dclarizio dclarizio

Labels
blocker bug compute/infrastructure euwe/backported fine/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lgalis @miq-bot @chrispy1 @simaishi @dclarizio