-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse the column/field name correctly in reports #1170
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jntullo
force-pushed
the
bz/style_report_columns
branch
from
April 27, 2017 17:43
8f1d33f
to
e070f0d
Compare
update method name
jntullo
force-pushed
the
bz/style_report_columns
branch
from
April 27, 2017 18:23
e070f0d
to
c85cea2
Compare
Checked commit jntullo@c85cea2 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
jntullo
changed the title
[WIP] Parse the column/field name correctly in reports
Parse the column/field name correctly in reports
Jun 6, 2017
@miq-bot assign @dclarizio dependent PR has been merged |
h-kataria
approved these changes
Jun 6, 2017
simaishi
pushed a commit
that referenced
this pull request
Jun 12, 2017
Parse the column/field name correctly in reports (cherry picked from commit 7da9572) https://bugzilla.redhat.com/show_bug.cgi?id=1460761
Fine backport details:
|
Euwe backport (to manageiq repo) details:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1402547
When creating a report, the field names were not being stored properly in
col_options
because of how the field was being parsed.For example, the field
Vm.miq_provision.miq_request-requester_name
was being parsed asmiq_request.v_approved_by
instead of the correctmiq_provision.miq_request.v_approved_by
, causing theMiqExpression
to never evaluate to true and therefore not styling the report correctly. This PR leverages a new function added toMiqExpression::Field
to get the correct column nameHere are some gifs to display what was happening (sorry, they're a bit long):
Before:
After:
@miq-bot add_label cloud intel/reporting, wip, bug