Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IE 11 & Edge styling issue in Topology legend #1155

Merged
merged 1 commit into from
May 3, 2017
Merged

Fix IE 11 & Edge styling issue in Topology legend #1155

merged 1 commit into from
May 3, 2017

Conversation

epwinchell
Copy link
Contributor

@epwinchell epwinchell commented Apr 25, 2017 •
edited
Loading

This PR fixes a issue where the Topology entity icons are cropped in both IE11 & Edge
https://bugzilla.redhat.com/show_bug.cgi?id=1444119

Old:
screen shot 2017-04-25 at 2 03 03 pm

New:
screen shot 2017-04-25 at 1 46 51 pm

@epwinchell
Copy link
Contributor Author

@miq-bot add_label, bug, formatting/styling, euwe/yes, fine/yes

@miq-bot
Copy link
Member

miq-bot commented Apr 25, 2017

@epwinchell Cannot apply the following label because they are not recognized:

@epwinchell
Copy link
Contributor Author

epwinchell commented Apr 25, 2017 •
edited
Loading

@bmclaughlin Please review/test. This is an IE11-specific hack that should not affect Edge (please test there, as well.) If you have a better solution, your suggestions are welcomed. Thanks.

@epwinchell
Copy link
Contributor Author

@miq-bot assign @bmclaughlin

@epwinchell epwinchell changed the title Fix IE styling issue in Topology legend Fix IEn 11 styling issue in Topology legend Apr 25, 2017
@epwinchell epwinchell changed the title Fix IEn 11 styling issue in Topology legend Fix IE 11 styling issue in Topology legend Apr 25, 2017
@dclarizio dclarizio requested a review from bmclaughlin April 25, 2017 19:56
@dclarizio dclarizio assigned dclarizio and unassigned bmclaughlin Apr 25, 2017
@epwinchell epwinchell changed the title Fix IE 11 styling issue in Topology legend Fix IE 11 & Edge styling issue in Topology legend May 1, 2017
bmclaughlin
bmclaughlin approved these changes May 1, 2017
View reviewed changes
Copy link
Contributor

@bmclaughlin bmclaughlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked changes in both IE11 and Edge browsers, works as advertised.

@miq-bot
Copy link
Member

miq-bot commented May 1, 2017

Checked commit https://github.com/epwinchell/manageiq-ui-classic/commit/b64bb9b0087c9f96a51fdab8aac0848428e4549e with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@martinpovolny martinpovolny merged commit 5952636 into ManageIQ:master May 3, 2017
@martinpovolny martinpovolny added this to the Sprint 60 Ending May 8, 2017 milestone May 3, 2017
@simaishi
Copy link
Contributor

Euwe backport (to manageiq repo) details:

$ git log -1
commit e16b2b3e756481928de70587466c313a185cf848
Author: Martin Povolny <[email protected]>
Date:   Wed May 3 22:18:31 2017 +0200

    Merge pull request #1155 from epwinchell/ie11_topology_fix
    
    Fix IE 11 & Edge styling issue in Topology legend
    (cherry picked from commit 5952636c98441037a08878b39a6618fbcecfcf2e)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1449404

simaishi pushed a commit that referenced this pull request Jun 5, 2017
@martinpovolny @simaishi
Merge pull request #1155 from epwinchell/ie11_topology_fix
d45fce6 
Fix IE 11 & Edge styling issue in Topology legend
(cherry picked from commit 5952636)

https://bugzilla.redhat.com/show_bug.cgi?id=1458929
@simaishi
Copy link
Contributor

simaishi commented Jun 5, 2017

Fine backport details:

$ git log -1
commit d45fce68464652be5fe61ae8c511e15e2e4fb98b
Author: Martin Povolny <[email protected]>
Date:   Wed May 3 22:18:31 2017 +0200

    Merge pull request #1155 from epwinchell/ie11_topology_fix
    
    Fix IE 11 & Edge styling issue in Topology legend
    (cherry picked from commit 5952636c98441037a08878b39a6618fbcecfcf2e)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1458929

@epwinchell epwinchell deleted the ie11_topology_fix branch March 20, 2019 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmclaughlin bmclaughlin bmclaughlin approved these changes

Assignees

@martinpovolny martinpovolny

Labels
bug euwe/backported fine/backported formatting/styling topology
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@epwinchell @miq-bot @simaishi @bmclaughlin @martinpovolny @dclarizio