-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename column header in Container Template screen #1147
Conversation
@miq-bot add_label compute/containers, bug |
Awaiting feedback on #1147 (comment) from @simon3z / @zeari . . . we're green and can merge if we get the 👍 |
@dclarizio Good enough for me but its up to @simon3z. I think Its really more up to to users to know that openshift generates names. Maybe we can distinguish between names that the user is required to fill out and the ones that are auto generated? |
864ed33
to
d8160b0
Compare
@epwinchell Can you please take a look? I'm not sure regarding the text styling here. |
@zakiva Looks fine |
@zakiva @epwinchell I have the feeling that the note should look like more a note (e.g. smaller font, maybe gray, closer to the table). |
@zakiva Try using %small rather than %h4 (https://rawgit.com/patternfly/patternfly/master-dist/dist/tests/typography-2.html) |
d8160b0
to
0e56479
Compare
@epwinchell done, thanks |
Checked commit zakiva@0e56479 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
@dclarizio Can you please review/merge? |
Rename column header in Container Template screen (cherry picked from commit 03b8ff1) https://bugzilla.redhat.com/show_bug.cgi?id=1460372
Fine backport details:
|
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1434760
Adding a note to clarify that the objects names can consist of parameters.