Display paging controls on PXE/Customization Templates list #1135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label bug |
jzigmund
force-pushed
the
bz1442751-fix_paging_ctrls_pxe_custom_templates
branch
from
5d813bd to
67e62c0
Compare
h-kataria
reviewed
Apr 24, 2017
app/controllers/pxe_controller.rb
Outdated
| presenter.reset_one_trans | ||
| presenter.one_trans_ie if %w(save reset).include?(params[:button]) && is_browser_ie? | ||
| presenter.update(:paging_div, r[:partial => "layouts/x_pagingcontrols"]) | ||
| unless params[:ppsetting] |
There was a problem hiding this comment.
@jzigmund wondering if we need this check, if @in_a_form is set params[:ppsetting] should not be present in that case.
There was a problem hiding this comment.
yea right, it's not needed, I've put it there previously to avoid nil on local variable nodes, that I found as unused later and removed it in this PR .. so the conditional is not needed here .. good catch ;-)
jzigmund
force-pushed
the
bz1442751-fix_paging_ctrls_pxe_custom_templates
branch
from
67e62c0 to
c4e64b0
Compare
|
Checked commit jzigmund@c4e64b0 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 app/controllers/pxe_controller.rb
|
|
@h-kataria updated PR, removed unnecessary conditional according to your review comment |
|
LGTM, test failures are not related to changes in this PR. |
simaishi
pushed a commit
that referenced
this pull request
Apr 24, 2017
…_custom_templates Display paging controls on PXE/Customization Templates list (cherry picked from commit 1e3a585)
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added updating
paging_divwith the x_pagingcontrols partial view and fixed double rendered error.Previously the paging controls were not displayed when user came to the list view through selected group of the templates in the tree (tree_select - JS request), but after refresh the page (explorer - HTML request) the controls have been displayed, and when user changed the paging settings it finished with double render error.
https://bugzilla.redhat.com/show_bug.cgi?id=1442751