Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix calendar position on C & U gap collection tab #1084

Merged
merged 1 commit into from
Apr 19, 2017
Merged

Fix calendar position on C & U gap collection tab #1084

merged 1 commit into from
Apr 19, 2017

Conversation

epwinchell
Copy link
Contributor

@epwinchell epwinchell commented Apr 19, 2017 •
edited
Loading

This PR forces the datapicker box to drop-down so that the controls aren't cropped by the toolbar.

https://bugzilla.redhat.com/show_bug.cgi?id=1439853

Old
screen shot 2017-04-19 at 2 16 53 pm

New
screen shot 2017-04-19 at 2 16 34 pm

@epwinchell
Copy link
Contributor Author

@miq-bot add_label bug, euwe/yes, fine/yes

@epwinchell
Copy link
Contributor Author

@miq-bot assign @h-kataria

@h-kataria
Copy link
Contributor

looks good.

@miq-bot
Copy link
Member

miq-bot commented Apr 19, 2017

Checked commit https://github.com/epwinchell/manageiq-ui-classic/commit/42fe5f384eb5464b3553df58721ddb59cc10294f with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks good. 👍

@h-kataria h-kataria added this to the Sprint 59 Ending Apr 24, 2017 milestone Apr 19, 2017
@h-kataria h-kataria merged commit 8c609eb into ManageIQ:master Apr 19, 2017
@epwinchell
Copy link
Contributor Author

@miq-bot add_label formatting/styling

simaishi pushed a commit that referenced this pull request Apr 20, 2017
@h-kataria @simaishi
Merge pull request #1084 from epwinchell/c_and_u_gap_calendar_fix
859a58c 
Fix calendar position on C & U gap collection tab
(cherry picked from commit 8c609eb)
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit 859a58cf0159d07e2c7929eec0900ca517a7ec4b
Author: Harpreet Kataria <[email protected]>
Date:   Wed Apr 19 16:05:11 2017 -0400

    Merge pull request #1084 from epwinchell/c_and_u_gap_calendar_fix
    
    Fix calendar position on C & U gap collection tab
    (cherry picked from commit 8c609eb1719ce8cc50bd6920a3349ba92b477fb4)

@simaishi simaishi mentioned this pull request Apr 24, 2017
Merged
@simaishi
Copy link
Contributor

Euwe backport (to manageiq repo) details:

$ git log -1
commit adce7dc14baacdd48d1e51772443be4d4b98bea9
Author: Harpreet Kataria <[email protected]>
Date:   Wed Apr 19 16:05:11 2017 -0400

    Merge pull request #1084 from epwinchell/c_and_u_gap_calendar_fix
    
    Fix calendar position on C & U gap collection tab
    (cherry picked from commit 8c609eb1719ce8cc50bd6920a3349ba92b477fb4)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1446787

@epwinchell epwinchell deleted the c_and_u_gap_calendar_fix branch October 25, 2017 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@h-kataria h-kataria

Labels
bug euwe/backported fine/backported formatting/styling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@epwinchell @h-kataria @miq-bot @simaishi