Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide back button on provider dashboard screens #1040

Merged
merged 1 commit into from
Apr 18, 2017

Conversation

hayesr
Copy link
Contributor

@hayesr hayesr commented Apr 13, 2017

Currently the back button is displayed on provider dashboards but they are non-functional. This removes the button.

Addresses
https://bugzilla.redhat.com/show_bug.cgi?id=1441956

Testing
I checked the container and infra providers dashboards, both had this behavior.

Before
screen shot 2017-04-13 at 11 46 53 am

After
screen shot 2017-04-13 at 11 45 04 am

@hayesr
Copy link
Contributor Author

hayesr commented Apr 13, 2017

/cc @dclarizio

@miq-bot add_label bug, fine/yes

@dclarizio
Copy link

@hayesr I'm thinking just add a return false if .... before the existing code in this PR, then do an upstream refactoring to make this easier to read.

@dclarizio dclarizio self-assigned this Apr 13, 2017
@hayesr hayesr force-pushed the fix_back_btn_dashboards branch from db6affe to 6fcab4c Compare April 17, 2017 14:09
@hayesr
Copy link
Contributor Author

hayesr commented Apr 17, 2017

@dclarizio Ready to go.

@miq-bot
Copy link
Member

miq-bot commented Apr 17, 2017

Checked commit hayesr@6fcab4c with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. 🍰

@dclarizio dclarizio merged commit ac5570e into ManageIQ:master Apr 18, 2017
@dclarizio dclarizio added this to the Sprint 59 Ending Apr 24, 2017 milestone Apr 18, 2017
simaishi pushed a commit that referenced this pull request Apr 18, 2017
Hide back button on provider dashboard screens
(cherry picked from commit ac5570e)

https://bugzilla.redhat.com/show_bug.cgi?id=1443113
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit 2e6e0caadb71139b44d02fa3f4c6b65a469ef020
Author: Dan Clarizio <[email protected]>
Date:   Tue Apr 18 02:09:23 2017 -0700

    Merge pull request #1040 from hayesr/fix_back_btn_dashboards
    
    Hide back button on provider dashboard screens
    (cherry picked from commit ac5570ef2bf4318ffa2ca3017962f6fb0e7a9af0)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1443113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants