Add support for fonticons in TreeBuilder root nodes #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skateman
force-pushed
the
tree-root-options
branch
6 times, most recently
from
17616f1 to
492c933
Compare
|
This pull request is not mergeable. Please rebase and repush. |
skateman
force-pushed
the
tree-root-options
branch
from
492c933 to
bec2093
Compare
|
@skateman Cannot apply the following label because they are not recognized: technical_debt |
|
@miq-bot add_label technical debt |
skateman
force-pushed
the
tree-root-options
branch
from
bec2093 to
ed74d2a
Compare
skateman
force-pushed
the
tree-root-options
branch
from
ed74d2a to
a8fac8e
Compare
|
@himdel I love free 🍻 😉 |
skateman
force-pushed
the
tree-root-options
branch
from
a8fac8e to
d7a3ba5
Compare
|
Checked commits skateman/manageiq-ui-classic@7e02ea5~...d7a3ba5 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 spec/presenters/tree_builder_policy_simulation_results_spec.rb
spec/presenters/tree_builder_spec.rb
|
himdel
reviewed
Jan 10, 2017
| { | ||
| :title => @root.name, | ||
| :tooltip => _("Host: %{name}") % {:name => @root.name}, | ||
| :image => '100/host.png', |
There was a problem hiding this comment.
@epwinchell there's a few more pngs in the TreeBuilders to convert...
There was a problem hiding this comment.
@himdel we know :) but no one likes monstercommits
|
LGTM, tested in the UI :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we're supporting images and icons at the same time, it was necessary to modify all the
root_optionsmethods to return with a Hash instead of an Array. This way it will be possible to specify an:iconor an:imagethe same way as forTreeNode::Hash. Also the fallback folder image has been changed to a folder fonticon.