Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistencies regarding responding of Add/Save button while adding/editing Group #5941

Closed
hstastna opened this issue Aug 5, 2019 · 4 comments
Assignees
Labels

Comments

@hstastna
Copy link

hstastna commented Aug 5, 2019

There are inconsistencies of responding Add/Save button while adding/editing a Group. In some pages, Add button becomes enabled when it is anything filled in (no matter if there is all the required info filled in or not), and in other pages, the button becomes enabled only if there is all the required info filled in (ops_rbac, Zones).

For adding Groups, there is an extra logic in the code, which is about checking if Role and Project/Tenant is set. That's different to the behavior in other pages because it is not just responding to any change, also not checking if all the required info is filled in.

So I suggest improvements for Add/Save button regarding responses on changes: me and @romanblanco think that Add button should be enabled after filling ALL the required info while adding Group (some related comments are also here). Also, we may want to mark the appropriate fields/info as required while adding new Group. Plus we may want to see Save button responding to any change properly while editing an existing Group.


Scenario 1:(adding new Group)

  1. Configuration > Access Control > Groups (accordion)
  2. Configuration (toolbar) > Add a new Group
  3. Choose some Role and Project/Tenant from the drop downs
    => Add button becomes enabled even when Description is required

Note:
After clicking on Add, proper flash message is displayed, we cannot create a new Group without specifying all the required info. This works fine, at least.


Scenario 2: (editing an existing Group)

  1. Configuration > Access Control > Groups (accordion)
  2. Choose some existing group (checkbox or go to details page of some Group)
  3. Configuration (toolbar) > Edit this Group
  4. Change anything under Group Information section
  5. Now make such changes that there will be no difference between the original info and actual one (don't use Reset)
    => Save button enabled even when there is nothing to save!

edit_group

@hstastna
Copy link
Author

hstastna commented Aug 5, 2019

#5815 should help with responding Save button while editing Group but I've found another issue in the code, regarding filters.

hstastna pushed a commit to hstastna/manageiq-ui-classic that referenced this issue Aug 6, 2019
hstastna pushed a commit to hstastna/manageiq-ui-classic that referenced this issue Aug 7, 2019
@Fryguy Fryguy added the bug label Aug 13, 2019
@h-kataria h-kataria assigned hstastna and unassigned h-kataria Aug 16, 2019
@h-kataria
Copy link
Contributor

@hstastna please close if this has already been fixed.

@hstastna
Copy link
Author

The appropriate PRs are not merged yet.

@hstastna
Copy link
Author

hstastna commented Sep 19, 2019

Update:
After some discussions and investigation, I've found that the extra logic in ops_rbac.rb to check if required fields are filled in, is special, not common. It was added while fixing some BZ in the past. To achieve more consistency, we want to remove it here. We want validation of the data filled in the form AFTER clicking on Add/Save button.

I'm closing this issue as other issues are already fixed and appropriate PRs merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants