-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistencies regarding responding of Add/Save button while adding/editing Group #5941
Comments
#5815 should help with responding Save button while editing Group but I've found another issue in the code, regarding filters. |
@hstastna please close if this has already been fixed. |
The appropriate PRs are not merged yet. |
Update: I'm closing this issue as other issues are already fixed and appropriate PRs merged. |
There are inconsistencies of responding Add/Save button while adding/editing a Group. In some pages, Add button becomes enabled when it is anything filled in (no matter if there is all the required info filled in or not), and in other pages, the button becomes enabled only if there is all the required info filled in (ops_rbac, Zones).
For adding Groups, there is an extra logic in the code, which is about checking if Role and Project/Tenant is set. That's different to the behavior in other pages because it is not just responding to any change, also not checking if all the required info is filled in.
So I suggest improvements for Add/Save button regarding responses on changes: me and @romanblanco think that Add button should be enabled after filling ALL the required info while adding Group (some related comments are also here). Also, we may want to mark the appropriate fields/info as required while adding new Group. Plus we may want to see Save button responding to any change properly while editing an existing Group.
Scenario 1:(adding new Group)
=> Add button becomes enabled even when Description is required
Note:
After clicking on Add, proper flash message is displayed, we cannot create a new Group without specifying all the required info. This works fine, at least.
Scenario 2: (editing an existing Group)
=> Save button enabled even when there is nothing to save!
The text was updated successfully, but these errors were encountered: