cannot create a group after validation message "already exists"

[lpichler]

1. create group 'test'
2. create group 'test' again - you will get validation message
3. So change name to any different (which does not exist). and click add - nothing will happen, see error message below.

error log

 FATAL -- : Error caught: [NoMethodError] undefined method `empty?' for nil:NilClass /Users/liborpichler/manageiq/manageiq-ui-classic/app/controllers/ops_controller/ops_rbac.rb:1372:in `rbac_group_validate?' /Users/liborpichler/manageiq/manageiq-ui-classic/app/controllers/ops_controller/ops_rbac.rb:669:in `rbac_edit_save_or_add' /Users/liborpichler/manageiq/manageiq-ui-classic/app/controllers/ops_controller/ops_rbac.rb:87:in `rbac_group_edit' /Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/actionpack-5.0.7.1/lib/action_controller/metal/basic_implicit_render.rb:4:in `send_action' /Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/actionpack-5.0.7.1/lib/abstract_controller/base.rb:188:in `process_action' /Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/actionpack-5.0.7.1/lib/action_controller/metal/rendering.rb:30:in `process_action' /Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/actionpack-5.0.7.1/lib/abstract_controller/callbacks.rb:20:in `block in process_action' /Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/activesupport-5.0.7.1/lib/active_support/callbacks.rb:126:in `call' /Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/activesupport-5.0.7.1/lib/active_support/callbacks.rb:506:in `block (2 levels) in compile' /Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/activesupport-5.0.7.1/lib/active_support/callbacks.rb:455:in `call' /Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/activesupport-5.0.7.1/lib/active_support/callbacks.rb:101:in `__run_callbacks__' /Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/activesupport-5.0.7.1/lib/active_support/callbacks.rb:750:in `_run_process_action_callbacks' /Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/activesupport-5.0.7.1/lib/active_support/callbacks.rb:90:in `run_callbacks' /Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/actionpack-5.0.7.1/lib/abstract_controller/callbacks.rb:19:in `process_action' /Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/actionpack-5.0.7.1/lib/action_controller/metal/rescue.rb:20:in `process_action' /Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/actionpack-5.0.7.1/lib/action_controller/metal/instrumentation.rb:32:in `block in process_action' /Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/activesupport-5.0.7.1/lib/active_support/notifications.rb:164:in `block in instrument' /Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/activesupport-5.0.7.1/lib/active_support/notifications/instrumenter.rb:21:in `instrument' /Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/activesupport-5.0.7.1/lib/active_support/notifications.rb:164:in `instrument' /Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/actionpack-5.0.7.1/lib/action_controller/metal/instrumentation.rb:30:in `process_action' /Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/actionpack-5.0.7.1/lib/action_controller/metal/params_wrapper.rb:248:in `process_action' /Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/activerecord-5.0.7.1/lib/active_record/railties/controller_runtime.rb:18:in `process_action' /Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/actionpack-5.0.7.1/lib/abstract_controller/base.rb:126:in `process' /Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/actionview-5.0.7.1/lib/action_view/rendering.rb:30:in `process' /Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/actionpack-5.0.7.1/lib/action_controller/metal.rb:190:in `dispatch' /Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/actionpack-5.0.7.1/lib/action_controller/metal.rb:262:in `dispatch' /Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/actionpack-5.0.7.1/lib/action_dispatch/routing/route_set.rb:50:in `dispatch' /Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/actionpack-5.0.7.1/lib/action_dispatch/routing/route_set.rb:32:in `serve' /Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/actionpack-5.0.7.1/lib/action_dispatch/journey/router.rb:39:in `block in serve' /Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/actionpack-5.0.7.1/lib/action_dispatch/journey/router.rb:26:in `each' /Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/actionpack-5.0.7.1/lib/action_dispatch/journey/router.rb:26:in `serve' /Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/actionpack-5.0.7.1/lib/action_dispatch/routing/route_set.rb:727:in `call' /Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/bundler/gems/manageiq-graphql-82fdd9385bdd/lib/manageiq/graphql/rest_api_proxy.rb:18:in `call' /Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/secure_headers-3.0.3/lib/secure_headers/middleware.rb:10:in `call' /Users/liborpichler/manageiq/manageiq/lib/request_started_on_middleware.rb:12:in `call' /Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/rack-2.0.6/lib/rack/etag.rb:25:in `call' /Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/rack-2.0.6/lib/rack/conditional_get.rb:38:in `call' /Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/rack-2.0.6/lib/rack/head.rb:12:in `call' /Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/rack-2.0.6/lib/rack/session/abstract/id.rb:232:in `context' /Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/rack-2.0.6/lib/rack/session/abstract/id.rb:226:in `call' /Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/actionpack-5.0.7.1/lib/action_dispatch/middleware/cookies.rb:613:in `call' /Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/actionpack-5.0.7.1/lib/action_dispatch/middleware/callbacks.rb:38:in `block in call' /Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/activesupport-5.0.7.1/lib/active_support/callbacks.rb:97:in `__run_callbacks__' /Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/activesupport-5.0.7.1/lib/active_support/callbacks.rb:750:in `_run_call_callbacks' /Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/activesupport-5.0.7.1/lib/active_support/callbacks.rb:90:in `run_callbacks' /Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/actionpack-5.0.7.1/lib/action_dispatch/middleware/callbacks.rb:36:in `call' /Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/actionpack-5.0.7.1/lib/action_dispatch/middleware/executor.rb:12:in `call' /Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/actionpack-5.0.7.1/lib/action_dispatch/middleware/remote_ip.rb:79:in `call' /Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/actionpack-5.0.7.1/lib/action_dispatch/middleware/debug_exceptions.rb:49:in `call' /Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/actionpack-5.0.7.1/lib/action_dispatch/middleware/show_exceptions.rb:31:in `call' /Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/railties-5.0.7.1/lib/rails/rack/logger.rb:36:in `call_app' /Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/railties-5.0.7.1/lib/rails/rack/logger.rb:26:in `call' /Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/sprockets-rails-3.2.1/lib/sprockets/rails/quiet_assets.rb:13:in `call' /Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/actionpack-5.0.7.1/lib/action_dispatch/middleware/request_id.rb:24:in `call' /Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/rack-2.0.6/lib/rack/method_override.rb:22:in `call' /Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/rack-2.0.6/lib/rack/runtime.rb:22:in `call' /Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/activesupport-5.0.7.1/lib/active_support/cache/strategy/local_cache_middleware.rb:28:in `call' /Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/actionpack-5.0.7.1/lib/action_dispatch/middleware/executor.rb:12:in `call' /Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/actionpack-5.0.7.1/lib/action_dispatch/middleware/static.rb:136:in `call' /Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/rack-2.0.6/lib/rack/sendfile.rb:111:in `call' /Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/railties-5.0.7.1/lib/rails/engine.rb:522:in `call' /Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/puma-3.7.1/lib/puma/configuration.rb:232:in `call' /Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/puma-3.7.1/lib/puma/server.rb:578:in `handle_request' /Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/puma-3.7.1/lib/puma/server.rb:415:in `process_client' /Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/puma-3.7.1/lib/puma/server.rb:275:in `block in run' /Users/liborpichler/manageiq/manageiq/.bundle/ruby/2.4.0/gems/puma-3.7.1/lib/puma/thread_pool.rb:120:in `block in spawn_thread' [----] I, [2019-01-08T18:04:32.462944 #11003:3fd73df3d744]  INFO -- :   Rendered /Users/liborpichler/manageiq/manageiq-ui-classic/app/views/layouts/_exception_contents.html.haml (0.2ms)

[hstastna]

Note:
I've tested this and was able to reproduce on the latest master branch, also on latest gaprindashvili and hammer. So I think we need to open a BZ ticket for this, @lpichler. Don't we?

[hstastna]

fixing: #5354

[hstastna]

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1690889

[lpichler]

thanks @hstastna !