Permanently deleted app/helpers/ui_constants.rb ... end of issue #1661

ManageIQ · Sep 12, 2017 · f3aaf08 · f3aaf08
1 parent 01005a0
commit f3aaf08
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 17 deletions.
diff --git a/app/helpers/ui_constants.rb b/app/helpers/ui_constants.rb
diff --git a/lib/manageiq/ui/classic/engine.rb b/lib/manageiq/ui/classic/engine.rb
@@ -42,11 +42,6 @@ class Engine < ::Rails::Engine
           )
         end
 
-        config.after_initialize do
-          # HACK: Autoload UiConstants so other repos don't need to do this.  This file pollutes the global namespace for legacy bad reasons.
-          UiConstants
-        end
-
         def vmdb_plugin?
           true
         end

diff --git a/lib/report_formatter.rb b/lib/report_formatter.rb
@@ -1,8 +1,3 @@
-# Make these constants globally available
-# TODO: Stop including constants in Object via UiConstants module since these
-# singleton constants don't play nice with Rails class reloading in dev mode.
-# Either access the constants through the UiConstants namespace or get it to
-# work with including it in all the views/controllers via application_helper.
 include ActionView::Helpers::NumberHelper
 
 require 'report_formatter/report_renderer'

diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb
@@ -48,11 +48,9 @@
 
   config.include Spec::Support::AuthHelper, :type => :view
   config.include Spec::Support::ViewHelper, :type => :view
-  config.include UiConstants, :type => :view
 
   config.include Spec::Support::ControllerHelper, :type => :controller
   config.include Spec::Support::AuthHelper, :type => :controller
-  config.include UiConstants, :type => :controller
 
   config.include Spec::Support::AuthHelper, :type => :helper