Addressed rubocop warnings

Also deleted leftover routes for provider_foreman controller

app/controllers/configuration_manager_controller.rb

@@ -69,7 +69,7 @@ def button
 
   private
 
-  def self.model_to_name(provmodel)
+  def self.model_to_name(_provmodel)
     Dictionary.gettext('configuration_manager', :type => :ui_title, :translate => false)
   end
 

app/views/automation_manager/_form.html.haml

@@ -1 +1,2 @@
 = render :partial => 'configuration_manager/shared_form', :locals => {:url => "/automation_manager", :model => "automationManagerModel"}
+

app/views/configuration_manager/_shared_form.html.haml

@@ -97,3 +97,4 @@
   ManageIQ.angular.app.value('url', '#{url}');
   ManageIQ.angular.app.value('modelName', '#{model}');
   miq_bootstrap('#form_div');
+

app/views/configuration_manager/edit.html.haml

@@ -1 +1,2 @@
 = render :partial => 'configuration_manager/shared_form', :locals => {:url => "/configuration_manager", :model => "configurationManagerModel"}
+

app/views/configuration_manager/new.html.haml

@@ -1 +1,2 @@
 = render :partial => 'configuration_manager/shared_form', :locals => {:url => "/configuration_manager", :model => "configurationManagerModel"}
+

app/views/configuration_manager/show.html.haml

@@ -1,11 +1,11 @@
-- if %w(configuration_profiles configured_systems).include?(@display)
+- if %w[configuration_profiles configured_systems].include?(@display)
   = render :partial => "layouts/gtl", :locals => {:action_url => "show/#{@record.id}"}
 - elsif @showtype == "main"
   = render :partial => "layouts/flash_msg"
   .row
     .col-md-12.col-lg-6
-      = react 'GenericGroupWrapper', expand_generic_group(TextualGroup.new(_('Properties'), textual_group_properties), @record)
-      = react 'GenericGroupWrapper', expand_generic_group(TextualGroup.new(_('Relationships'), textual_group_relationships), @record)
+      = react('GenericGroupWrapper', expand_generic_group(TextualGroup.new(_('Properties'), textual_group_properties), @record))
+      = react('GenericGroupWrapper', expand_generic_group(TextualGroup.new(_('Relationships'), textual_group_relationships), @record))
     .col-md-12.col-lg-6
-      = react 'GenericGroupWrapper', expand_generic_group(TextualGroup.new(_('Status'), textual_group_status), @record)
-      = react 'GenericGroupWrapper', expand_generic_group(TextualTags.new(_('Smart Management'), textual_group_tags), @record)
+      = react('GenericGroupWrapper', expand_generic_group(TextualGroup.new(_('Status'), textual_group_status), @record))
+      = react('GenericGroupWrapper', expand_generic_group(TextualTags.new(_('Smart Management'), textual_group_tags), @record))

app/views/configuration_manager/show_list.html.haml

@@ -1,2 +1,3 @@
 #main_div
   = render :partial => 'layouts/gtl'
+

app/views/configuration_profile/show.html.haml

@@ -1,13 +1,13 @@
-- if %w(configured_systems).include?(@display)
+- if %w[configured_systems].include?(@display)
   = render :partial => "layouts/gtl", :locals => {:action_url => "show/#{@record.id}"}
 - elsif @showtype == "main"
   = render :partial => "layouts/flash_msg"
   .row
     .col-md-12.col-lg-6
-      = react 'GenericGroupWrapper', expand_generic_group(TextualGroup.new(_('Properties'), textual_configuration_profile_group_properties), @record)
-      = react 'GenericGroupWrapper', expand_generic_group(TextualGroup.new(_('Relationships'), textual_configuration_profile_group_relationships), @record)
-      = react 'GenericGroupWrapper', expand_generic_group(TextualGroup.new(_('Environment'), textual_configuration_profile_group_environment), @record)
+      = react('GenericGroupWrapper', expand_generic_group(TextualGroup.new(_('Properties'), textual_configuration_profile_group_properties), @record))
+      = react('GenericGroupWrapper', expand_generic_group(TextualGroup.new(_('Relationships'), textual_configuration_profile_group_relationships), @record))
+      = react('GenericGroupWrapper', expand_generic_group(TextualGroup.new(_('Environment'), textual_configuration_profile_group_environment), @record))
     .col-md-12.col-lg-6
-      = react 'GenericGroupWrapper', expand_generic_group(TextualGroup.new(_('Operating System'), textual_configuration_profile_group_os), @record)
-      = react 'GenericGroupWrapper', expand_generic_group(TextualGroup.new(_('Tenancy'), textual_configuration_profile_group_tenancy), @record)
+      = react('GenericGroupWrapper', expand_generic_group(TextualGroup.new(_('Operating System'), textual_configuration_profile_group_os), @record))
+      = react('GenericGroupWrapper', expand_generic_group(TextualGroup.new(_('Tenancy'), textual_configuration_profile_group_tenancy), @record))
 

app/views/layouts/_searchbar.html.haml

@@ -23,12 +23,12 @@
       .form-group
         %button.btn.btn-default{:type => "submit"}
           %span.fa.fa-search
-        %button{"type"          => "button",
-                :class          => "btn btn-default",
-                "data-toggle"   => "modal",
-                "data-target"   => "#advsearchModal",
-                :id             => "adv_search",
-                :title          => _("Advanced Search")}
+        %button{"type"        => "button",
+                :class        => "btn btn-default",
+                "data-toggle" => "modal",
+                "data-target" => "#advsearchModal",
+                :id           => "adv_search",
+                :title        => _("Advanced Search")}
           %span.fa.fa-angle-double-down
 
 :javascript

app/views/layouts/listnav/_configuration_manager.html.haml

@@ -14,13 +14,13 @@
       %ul.nav.nav-pills.nav-stacked
         - if role_allows?(:feature => "configuration_profile_show_list")
           = li_link(:count => @record.number_of(:configuration_profiles),
-            :record_id     => @record.id,
-            :tables        => 'configuration_profiles',
-            :display       => 'configuration_profiles',
-            :action        => 'show')
+            :record_id => @record.id,
+            :tables    => 'configuration_profiles',
+            :display   => 'configuration_profiles',
+            :action    => 'show')
         - if role_allows?(:feature => "configured_system_show_list")
           = li_link(:count => @record.number_of(:configured_systems),
-            :record_id     => @record.id,
-            :tables        => 'configured_systems',
-            :display       => 'configured_systems',
-            :action        => 'show')
+            :record_id => @record.id,
+            :tables    => 'configured_systems',
+            :display   => 'configured_systems',
+            :action    => 'show')

config/routes.rb

@@ -2659,7 +2659,7 @@
     },
 
     :configuration_manager  => {
-      :get  => %w(
+      :get  => %w[
         button
         download_data
         download_summary_pdf
@@ -2669,8 +2669,8 @@
         show
         show_list
         tagging_edit
-      ),
-      :post => %w(
+      ],
+      :post => %w[
         authentication_validate
         button
         change_tab
@@ -2687,37 +2687,37 @@
         tagging_edit
         tag_edit_form_field_changed
         wait_for_task
-      ) +
+      ] +
         adv_search_post +
         exp_post +
         save_post
     },
 
     :configuration_profile  => {
-      :get  => %w(
+      :get  => %w[
         download_data
         download_summary_pdf
         show
         show_list
-      ),
-      :post => %w(
+      ],
+      :post => %w[
         button
         quick_search
         reload
         show
         show_list
-      )
+      ]
     },
 
     :configured_system  => {
-      :get  => %w(
+      :get  => %w[
         download_data
         download_summary_pdf
         show
         show_list
         tagging_edit
-      ),
-      :post => %w(
+      ],
+      :post => %w[
         button
         new
         provision
@@ -2729,54 +2729,13 @@
         tagging_edit
         tag_edit_form_field_changed
         wait_for_task
-      ) +
+      ] +
         adv_search_post +
         dialog_runner_post +
         exp_post +
         save_post
     },
 
-    :provider_foreman         => {
-      :get  => %w(
-        download_data
-        download_summary_pdf
-        explorer
-        form_fields
-        show
-        show_list
-        tagging_edit
-      ),
-      :post => %w(
-        accordion_select
-        authentication_validate
-        button
-        change_tab
-        delete
-        edit
-        explorer
-        form_field_changed
-        new
-        provision
-        quick_search
-        refresh
-        reload
-        show
-        show_list
-        tagging
-        tagging_edit
-        tag_edit_form_field_changed
-        tree_autoload
-        tree_select
-        cs_form_field_changed
-        users
-        wait_for_task
-        x_button
-      ) +
-               adv_search_post +
-               exp_post +
-               x_post
-    },
-
     :pxe                      => {
       :get  => %w(
         explorer

spec/helpers/application_helper/toolbar_chooser_spec.rb

@@ -12,7 +12,7 @@
       end
 
       it "configuration_manager list screen" do
-        @view   = true
+        @view = true
         @lastaction = "show_list"
         expect(_toolbar_chooser.send(:center_toolbar_filename_classic)).to eq("configuration_managers_center_tb")
       end

spec/helpers/application_helper_spec.rb

@@ -976,7 +976,7 @@
     subject { helper.display_adv_search? }
 
     context 'Advanced search is visible for list views' do
-      %w(cloud_volume_snapshot cloud_volume_backup configuration_manager).each do |layout|
+      %w[cloud_volume_snapshot cloud_volume_backup configuration_manager].each do |layout|
         let(:layout) { layout }
         it 'returns true' do
           expect(subject).to be(true)