Merge pull request #4241 from romanblanco/misc_pref_method_change_update

Refactoring provision method to use new rbac call

app/controllers/mixins/actions/host_actions/misc.rb

@@ -218,33 +218,18 @@ def providehosts
         end
 
         def host_button_operation(method, display_name)
-          hosts = []
+          hosts = find_records_with_rbac(Host, checked_or_params).ids
+          process_hosts(hosts, method, display_name)
 
           # Either a list or coming from a different controller (eg from ems screen, go to its hosts)
           if @lastaction == "show_list" || @layout != "host"
-            hosts = find_checked_ids_with_rbac(Host)
-            if hosts.empty?
-              add_flash(_("No Hosts were selected for %{task}") % {:task => display_name}, :error)
-            else
-              process_hosts(hosts, method, display_name)
-            end
-
             if @lastaction == "show_list" # In host controller, refresh show_list, else let the other controller handle it
               show_list
               @refresh_partial = "layouts/gtl"
             end
-
           else # showing 1 host
-            if params[:id].nil? || Host.find_by(:id => params[:id]).nil?
-              add_flash(_("Host no longer exists"), :error)
-            else
-              hosts.push(find_id_with_rbac(Host, params[:id]))
-              process_hosts(hosts, method, display_name) unless hosts.empty?
-            end
-
             params[:display] = @display
             show
-
             # TODO: tells callers to go back to show_list because this Host may be gone
             # Should be refactored into calling show_list right here
             if method == 'destroy'

spec/controllers/mixins/actions/host_actions/misc_spec.rb

@@ -0,0 +1,23 @@
+describe Mixins::Actions::HostActions::Misc do
+  describe "#host_button_operation" do
+    let(:controller) do
+      return HostController.new
+    end
+    let(:admin_user) { FactoryGirl.create(:user, :role => "super_administrator") }
+    let!(:host) { FactoryGirl.create(:host) }
+
+    before do
+      stub_user(:features => :all)
+      EvmSpecHelper.create_guid_miq_server_zone
+      login_as admin_user
+      allow(User).to receive(:current_user).and_return(admin_user)
+      allow(controller).to receive(:process_hosts).with([host.id], 'refresh_ems', 'Refresh')
+      controller.instance_variable_set(:@_params, :id => Host.all.ids)
+    end
+
+    it "tests that find_records_with_rbac is called and does not fail" do
+      expect(controller).to receive(:find_records_with_rbac).with(Host, Host.all.ids).and_return(Host.all)
+      controller.send(:host_button_operation, 'refresh_ems', _('Refresh'))
+    end
+  end
+end