Skip to content

Commit

Permalink
Fix loop conditional on provisioning workflow volume form
Browse files Browse the repository at this point in the history
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1506466
The problem described in the BZ was occuring because the
loop that builds the volume provisioning form was checking
the wrong hash keys for its condition and terminating
early.
  • Loading branch information
mansam committed Nov 30, 2017
1 parent 2f270bb commit 88b3443
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion app/views/miq_request/_prov_dialog_volume_fieldset.html.haml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

.form-horizontal#add-volumes-form
- while (draw_fields)
= options
#add-volume-fieldset
- keys.each do |key|
.form-group
Expand Down Expand Up @@ -47,7 +48,7 @@
%hr
%div
- counter += 1
- draw_fields = !options[:"volume_name_#{counter}"].blank? && !options[:"volume_size_#{counter}"].blank?
- draw_fields = !options[:"name_#{counter}"].blank? && !options[:"size_#{counter}"].blank?

:javascript
(function(){
Expand Down

0 comments on commit 88b3443

Please sign in to comment.