Merge pull request #3941 from himdel/registry-component-class

Component registry - support both pure function component and class components
ManageIQ · May 15, 2018 · 6ae6bf2 · 6ae6bf2
2 parents 8ba5ee0 + 574e8ca
commit 6ae6bf2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/app/javascript/miq-component/react-blueprint.tsx b/app/javascript/miq-component/react-blueprint.tsx
@@ -14,13 +14,13 @@ import {
 // should fix the problem
 
 export default (
-  reactElementCreator: (props: ComponentProps) => any /* ReactElement */,
+  ReactElement: (props: ComponentProps) => any,
   mapPropsToInteract: (props: ComponentProps) => any = () => undefined
 ): ComponentBlueprint => {
   function render(props: ComponentProps, container: HTMLElement) {
     ReactDOM.render(
       <Provider store={ManageIQ.redux.store}>
-        {reactElementCreator(props)}
+        <ReactElement {...props} />
       </Provider>,
       container
     );

diff --git a/app/javascript/packs/component-definitions-common.js b/app/javascript/packs/component-definitions-common.js
@@ -3,5 +3,5 @@ import React from 'react';
 /**
 * Add component definitions to this file.
 * example of component definition:
-* ManageIQ.component.addReact('ComponentName', props => <ComponentName {...props} />);
+* ManageIQ.component.addReact('ComponentName', ComponentName);
 */