Merge pull request #638 from romanblanco/application_controller_cleanup

Making application helper methods more readable

app/helpers/application_helper.rb

@@ -143,13 +143,14 @@ def hidden_tag_if(tag, condition, options = {}, &block)
     end
   end
 
-  def no_hover_class(item)
-    klass = if item[:link]
-              ""
-            elsif item.has_key?(:value)
-              "" if item[:value].kind_of?(Array) && item[:value].any? {|val| val[:link]}
-            end
-    klass.nil? ? 'no-hover' : ''
+  def hover_class(item)
+    if item.fetch_path(:link) ||
+       item.fetch_path(:value).kind_of?(Array) &&
+       item[:value].any? { |val| val[:link] }
+      'no-hover'
+    else
+      ''
+    end
   end
 
   # Check role based authorization for a UI task
@@ -161,6 +162,7 @@ def role_allows?(**options)
 
     Rbac.role_allows?(options.merge(:user => User.current_user)) rescue false
   end
+
   module_function :role_allows?
   public :role_allows?
   alias_method :role_allows, :role_allows?
@@ -174,7 +176,10 @@ def model_to_controller(record)
 
   def controller_to_model
     case self.class.model.to_s
-    when "ManageIQ::Providers::CloudManager::Template", "ManageIQ::Providers::CloudManager::Vm", "ManageIQ::Providers::InfraManager::Template", "ManageIQ::Providers::InfraManager::Vm"
+    when "ManageIQ::Providers::CloudManager::Template",
+         "ManageIQ::Providers::CloudManager::Vm",
+         "ManageIQ::Providers::InfraManager::Template",
+         "ManageIQ::Providers::InfraManager::Vm"
       VmOrTemplate
     else
       self.class.model

app/views/shared/summary/_textual.html.haml

@@ -15,7 +15,7 @@
         - else
           - click = "DoNav('#{item[:link]}');"
 
-        %tr{:class   => no_hover_class(item),
+        %tr{:class   => hover_class(item),
             :title   => item[:title] ? item[:title] : "",
             :onclick => item[:link] ? click : ""}
           %td.label