Add method call parens ignores for RSpec #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bdunne Please review. |
|
Was this an issue somewhere? This cop currently ignores everything in the spec directory, that's why we don't have these in the list. Are you planning to remove the |
|
Then it must not be working because I get this error everywhere. See ManageIQ/manageiq#20731 (comment) for example |
Fryguy
added a commit
to Fryguy/manageiq-style
that referenced
this pull request
Nov 10, 2020
When Excludes are present in an inherited configuration file, Rubocop will expand_path them. However, the Excludes in .rubocop_base.yml were being resolved relative to the gem itself. Because of this they were ultimately ignored. The reason this happens is because Rubocop looks at the filename, and if it starts with .rubocop, it assumes that is a project-level file, and will expand relative to the file itself. Rubocop's own default config intentionally does _not_ start with .rubocop, as so the default config is expanded relative to the project. See https://github.com/rubocop-hq/rubocop/blob/eb3d3583/lib/rubocop/config.rb#L190-L203 The simplest fix for now is to just rename our files to not have .rubocop at the start of the file name. We can still keep our .rubocop_base.yml to avoid renaming it in all of the gems. Fixes ManageIQ#7 Closes ManageIQ#8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example when we do this: