Snapshot Support for Non-Managed Disks #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case of non-Managed (Blob) disks, append the snapshot name (which is in all actuality the date tag returned from azure-armrest for the snapshot) to the URI to be used to read the disk.
Since the MiqAzureVm now expects a ResourceGroup Object rather than the string representing its name, the tests need to be fixed to expect the modified parameter.
roliveri
suggested changes
Sep 11, 2017
lib/MiqVm/miq_azure_vm.rb
Outdated
| # | ||
| @uri = os_disk.vhd.uri | ||
| @uri << "?snapshot=" << args[:snapshot] if args[:snapshot] |
There was a problem hiding this comment.
Is
@uri << "?snapshot=#{args[:snapshot]}" if args[:snapshot]preferred?
Change string concatenation statement for snapshot URI.
|
Checked commits jerryk55/manageiq-smartstate@eacb131~...b003c9d with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
roliveri
approved these changes
Sep 11, 2017
|
@miq-bot add_label fine/yes |
|
@jerryk55 Cannot apply the following label because they are not recognized: fine/yes |
|
Fine backport (to manageiq-gems-pending repo) details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case of non-Managed (Blob) disks, append the snapshot
name (which is in all actuality the date tag returned from
azure-armrest for the snapshot) to the URI to be used to read
the disk.
This is one of several PRs required to fix https://bugzilla.redhat.com/show_bug.cgi?id=1463780.
The PR against ManageIQ/manageiq is ManageIQ/manageiq#15960, and one against ManageIQ/manageiq-providers-azure will be noted here when it is added.
This PR can be merged in any order since it checks for a tag to be passed in and only uses that snapshot tag if it is there.
@roliveri @hsong-rh please review. I'm not sure if we need to back port this to Fine but it wouldn't be a bad idea.