Re-Record Azure Managed Disks SSA Tests #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to an as yet undiagnosed dependency on a change in another gem/repo, these test recordings were no longer working even after working correctly at the time of the previous PR's merge. They have been re-recorded to get the tests back up and running.
Change the gem version to 0.1.3. Part of https://bugzilla.redhat.com/show_bug.cgi?id=1475540
|
Checked commits jerryk55/manageiq-smartstate@0c88470~...a70475e with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
roliveri
approved these changes
Sep 5, 2017
jerryk55
added a commit
to jerryk55/manageiq-gems-pending
that referenced
this pull request
Sep 6, 2017
ManageIQ/manageiq-smartstate#23 and ManageIQ/manageiq-smartstate#25 were added as part of the work required for blocker bug https://bugzilla.redhat.com/show_bug.cgi?id=1475540. This commit and subsequent PR track the backport of the changes into the Fine release.
This was referenced Sep 6, 2017
|
Backported to Fine via ManageIQ/manageiq-gems-pending#267 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to an as yet undiagnosed dependency on a change in another gem/repo,
these test recordings were no longer working even after working correctly at the time
of the previous PR's merge. They have been re-recorded to get the tests back up
and running.
The tests were initially recorded as part of #23.
@roliveri please review and merge (so we can get going on the rest of the required PRs for
Blocker bug https://bugzilla.redhat.com/show_bug.cgi?id=1475540) Thanks.