Add sub_metric column to chargeback_rate_detail #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example: We can have more cloud volume types of for allocated storate metric.
lpichler
force-pushed
the
add_sub_metric_to_chargeback_rate_detail
branch
from
6caf798 to
c31f9a4
Compare
|
Checked commit lpichler@c31f9a4 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for implementation for chargeback of storage (cloud volume) type.
Metric for allocated storage is now divided according to storage types and we need to store cloud volume type for the ChargebackRateDetail (the be able get metric value and then calculate cost)
So generally: it is adding posibility to divide metric to the small pieces - so this is the why I am calling it 'sub metric'.
In rate editor:
(gp2, .. - are cloud volume storage types)
cc @gtanzillo
@miq-bot assign @Fryguy