Clone owner_id to group_id in miq_sets table for dashboards assigned to group #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrudman
force-pushed
the
copy_owner_id-to-group_id-for-dashboards
branch
from
6fbcf44 to
9728104
Compare
…d to group This PR should go together with ManageIQ/manageiq#19491 Fixes issue ManageIQ/manageiq#18924
yrudman
force-pushed
the
copy_owner_id-to-group_id-for-dashboards
branch
from
9728104 to
d356240
Compare
Fryguy
reviewed
Nov 14, 2019
db/migrate/20191112132759_copy_owner_id_to_group_id_for_dashboards.rb
Outdated
Show resolved
Hide resolved
Fryguy
reviewed
Nov 14, 2019
db/migrate/20191112132759_copy_owner_id_to_group_id_for_dashboards.rb
Outdated
Show resolved
Hide resolved
Fryguy
reviewed
Nov 14, 2019
spec/migrations/20191112132759_copy_owner_id_to_group_id_for_dashboards_spec.rb
Show resolved
Hide resolved
Fryguy
reviewed
Nov 14, 2019
spec/migrations/20191112132759_copy_owner_id_to_group_id_for_dashboards_spec.rb
Outdated
Show resolved
Hide resolved
yrudman
changed the title
yrudman
force-pushed
the
copy_owner_id-to-group_id-for-dashboards
branch
from
113b89d to
c7bc1b4
Compare
yrudman
force-pushed
the
copy_owner_id-to-group_id-for-dashboards
branch
from
c7bc1b4 to
927a13d
Compare
Fryguy
reviewed
Nov 14, 2019
| describe CopyOwnerIdToGroupIdForDashboards do | ||
| let(:miq_set) { migration_stub(:MiqSet) } | ||
| let(:name) { "Hello Dashboard" } | ||
| let(:group_id) { 1 } |
There was a problem hiding this comment.
Don't hardcode the group_id as this is invalid in a multi-region mode. I believe there are specs where we need to create ids from an appropriate region, so search the specs for that...something around ActiveRecord::IdRegions.
There was a problem hiding this comment.
As agreed, we'll keep this as is, as it seems we don't have an existing mechanism for generating regionalized ids.
yrudman
force-pushed
the
copy_owner_id-to-group_id-for-dashboards
branch
4 times, most recently
from
ae1c430 to
ec0715b
Compare
|
Checked commits yrudman/manageiq-schema@d356240~...ec0715b with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 db/migrate/20191112132759_copy_owner_id_to_group_id_for_dashboards.rb
|
yrudman
force-pushed
the
copy_owner_id-to-group_id-for-dashboards
branch
from
ec0715b to
927a13d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should go together with ManageIQ/manageiq#19491
Fixes issue ManageIQ/manageiq#18924