[WIP] Move ConfigurationScriptSource#authentication to GitRepository #394
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to deal with the "double ownership problem" with ConfigurationScriptSource#authentication and GitRepository. The idea is that in the model we can delegate authentication stuff to the GitRepository. Thus, this migration first ensures that a git_repository exists, then moves the authentication over to it.
In GitRepository model, while it might have it's own authentication via AuthenticationMixin, we also add a separate
belongs_to :authentication
which is a referenced authentication. This way we can support both directly owned authentications and not-owned authentications.cc @gtanzillo @carbonin @agrare @NickLaMuro