Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add object_labels to Container Template #32

Merged
merged 1 commit into from
Sep 6, 2017

Conversation

zakiva
Copy link
Contributor

@zakiva zakiva commented Jul 5, 2017

Adding object_labels column to container_templates table.

Related PR: ManageIQ/manageiq#15406

@miq-bot add_label enhancement

cc @simon3z @lfu

@miq-bot
Copy link
Member

miq-bot commented Jul 26, 2017

This pull request is not mergeable. Please rebase and repush.

@miq-bot
Copy link
Member

miq-bot commented Aug 8, 2017

Checked commit zakiva@cc02fdf with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@zakiva
Copy link
Contributor Author

zakiva commented Aug 29, 2017

@simon3z Please review

@simon3z
Copy link
Contributor

simon3z commented Aug 29, 2017

OK on the approach 👍, let's get @zeari and @cben technical review/approval.

@Fryguy Fryguy merged commit fbb6876 into ManageIQ:master Sep 6, 2017
@Fryguy Fryguy added this to the Sprint 69 Ending Sep 18, 2017 milestone Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants