Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comments to the vms table #297

Merged
merged 23 commits into from
Nov 5, 2018
Merged

Add comments to the vms table #297

merged 23 commits into from
Nov 5, 2018

Conversation

djberg96
Copy link
Contributor

@djberg96 djberg96 commented Oct 25, 2018

As of Rails 5 we can add comments to tables and columns within the database. This is useful for developers, both within RedHat and externally, to help develop for the application.

As per the Rails 5 documentation, "It's highly recommended to specify comments in migrations for applications with large databases as it helps people to understand data model and generate documentation."

To that end I've begun with the vms table, and documented as much as I could. However, I need your help to finish it. Anywhere that you see the text "[DEFINITION NEEDED]" means I either don't know or don't fully understand what the column does and need someone to fill in that information for me.

(Originally #64, but got the rebase completely botched somehow, so resubmitting).

@mwperina
Copy link

@Fryguy
Copy link
Member

Fryguy commented Oct 26, 2018

@bdunne @agrare

@bdunne
Copy link
Member

bdunne commented Oct 26, 2018

👍 I like the idea, I'd like to populate as many of the definitions as possible before merge.

@djberg96
Copy link
Contributor Author

djberg96 commented Nov 5, 2018

@agrare Switched "change" to "up" as per your suggestion.

@Fryguy @agrare @bdunne I think it's ready to go.

@miq-bot
Copy link
Member

miq-bot commented Nov 5, 2018

Checked commits https://github.com/djberg96/manageiq-schema/compare/a84adee85d06af18d688d937343e681c67498f50~...a12453748734f4ec4d19d82b45bf4f5290c27d86 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@agrare agrare self-assigned this Nov 5, 2018
@agrare agrare merged commit 41e477e into ManageIQ:master Nov 5, 2018
@agrare agrare added this to the Sprint 98 Ending Nov 5, 2018 milestone Nov 5, 2018
@djberg96 djberg96 mentioned this pull request Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants