Add a test requiring data migrations to have an associated spec file #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdunne
force-pushed
the
data_migrations_need_tests
branch
2 times, most recently
from
d485d17 to
f930dbe
Compare
Fryguy
reviewed
Aug 9, 2018
|
|
||
| data_migration_files.each do |data_migration_file| | ||
| spec_file_basename = File.basename(data_migration_file).sub(".rb", "_spec.rb") | ||
| next if spec_file_basename.in?(KNOWN_MISSING_DATA_MIGRATION_SPEC_FILES) |
There was a problem hiding this comment.
I think move this down and XOR the comparison, such that if someone adds a test that's in the missing list, they are forced to remove it.
bdunne
force-pushed
the
data_migrations_need_tests
branch
from
f930dbe to
76a72cc
Compare
Fryguy
reviewed
Aug 9, 2018
| end | ||
| end | ||
|
|
||
| ActiveRecord::Base.singleton_class.prepend(Spec::Support::ConstantWatcher) |
There was a problem hiding this comment.
Can you verify this works locally if you do bundle exec rspec spec/specific/spec/file.rb
There was a problem hiding this comment.
Yes, it's loaded by spec_helper
|
#249 is merged, so please update the KNOWN list. |
We can determine which files are data migrations since they will define a class that inherits from ActiveRecord::Base. If we hook inherited in AR::Base, we can get the constant and the file in which it is defined (the data migration).
bdunne
force-pushed
the
data_migrations_need_tests
branch
from
76a72cc to
622e6fa
Compare
|
Checked commit bdunne@622e6fa with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can determine which files are data migrations since they will define a class that inherits from ActiveRecord::Base. If we hook inherited in AR::Base, we can get the constant and the file in which it is defined (the data migration).
Adding this as an automated code review to address #4 (comment)