-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrations for suspending provider #222
Closed
+274
−0
Closed
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
8767c08
Zone changes for suspending provider
slemrmartin c3dda92
Changed EMS's backup zone to bigint
slemrmartin d5a8fea
Fixes Zone namespace
slemrmartin 5904ac4
Splitting struct/data migrations
slemrmartin 43dedf3
Changes according to ManageIQ policy
slemrmartin 0192756
Renaming existing zone
slemrmartin a798122
Remove uniqueness validation from Zone.
slemrmartin a73f423
Region-aware renaming of zones
slemrmartin 59b1e78
Removing Maintenance zone seed from migration
slemrmartin 87bbb6a
Renaming maintenance zone's string associations.
slemrmartin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev
Previous commit
Renaming maintenance zone's string associations.
Like Job,MiqTask,MiqQueue + raises error when renaming existing zone to another existing.
commit 87bbb6a1e2aa5390dee39bfd64999402e83a7e1c
There are no files selected for viewing
82 changes: 74 additions & 8 deletions
82
db/migrate/20180626125655_rename_user_maintenance_zone_record.rb
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think this is the wrong approach
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bdunne you were worried about string associations
__maintenance__
as name is almost zerocould you be more specific? When this fails (with significant probability).
Is it not acceptable for @Fryguy, @agrare, @carbonin too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, but while unlikely, not impossible
Right now you're only updating
Job
andMiqQueue
. The following models have azone
column:I also believe it's in Settings and who knows how many other places it's buried in a serialized column. I just don't think it's practical to try renaming a zone