Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nil MiqDatabase#update_repo_name #191

Merged
merged 2 commits into from
Apr 27, 2018
Merged

Conversation

bdunne
Copy link
Member

@bdunne bdunne commented Apr 25, 2018

When migrating from 0, resulted in:

MoveRepoDataFromDatabaseToSettings#up handles nil update_repo_name
Failure/Error: described_class.migrate(migration_direction)

NoMethodError:
  undefined method `split' for nil:NilClass
# ./db/migrate/20160913195129_move_repo_data_from_database_to_settings.rb:15:in `block in up'
# /home/bdunne/.gem/ruby/2.4.3/gems/activerecord-5.0.6/lib/active_record/migration.rb:815:in `block in say_with_time'
# /home/bdunne/.gem/ruby/2.4.3/gems/activerecord-5.0.6/lib/active_record/migration.rb:815:in `say_with_time'
# ./db/migrate/20160913195129_move_repo_data_from_database_to_settings.rb:14:in `up'
# /home/bdunne/.gem/ruby/2.4.3/gems/activerecord-5.0.6/lib/active_record/migration.rb:792:in `exec_migration'
# /home/bdunne/.gem/ruby/2.4.3/gems/activerecord-5.0.6/lib/active_record/migration.rb:773:in `block (2 levels) in migrate'
# /home/bdunne/.gem/ruby/2.4.3/gems/activerecord-5.0.6/lib/active_record/migration.rb:772:in `block in migrate'
# /home/bdunne/.gem/ruby/2.4.3/gems/activerecord-5.0.6/lib/active_record/connection_adapters/abstract/connection_pool.rb:398:in `with_connection'
# /home/bdunne/.gem/ruby/2.4.3/gems/activerecord-5.0.6/lib/active_record/migration.rb:771:in `migrate'
# /home/bdunne/.gem/ruby/2.4.3/gems/activerecord-5.0.6/lib/active_record/migration.rb:601:in `migrate'
# ./spec/support/migration_helper.rb:71:in `migrate_under_test'
# ./spec/support/migration_helper.rb:35:in `block (2 levels) in migrate'
# ./spec/support/migration_helper.rb:83:in `suppress_migration_messages'
# ./spec/support/migration_helper.rb:35:in `block in migrate'
# ./spec/support/migration_helper.rb:57:in `clearing_caches'
# ./spec/support/migration_helper.rb:31:in `migrate'
# ./spec/migrations/20160913195129_move_repo_data_from_database_to_settings_spec.rb:44:in `block (3 levels) in <top (required)>'
# ./spec/support/migration_helper.rb:57:in `clearing_caches'
# ./spec/support/migration_helper.rb:13:in `block (2 levels) in migration_context'

Introduced in: ManageIQ/manageiq#11304

@bdunne
Copy link
Member Author

bdunne commented Apr 25, 2018

@miq-bot add_reviewer @Fryguy

@miq-bot miq-bot requested a review from Fryguy April 25, 2018 20:03
@bdunne
Copy link
Member Author

bdunne commented Apr 25, 2018

@miq-bot add_label gaprindashvili/yes

@miq-bot
Copy link
Member

miq-bot commented Apr 25, 2018

Checked commits bdunne/manageiq-schema@eab09b4~...35c75c0 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🏆

@Fryguy Fryguy merged commit 6182bd0 into ManageIQ:master Apr 27, 2018
@Fryguy Fryguy added this to the Sprint 85 Ending May 7, 2018 milestone Apr 27, 2018
@Fryguy Fryguy added the bug label Apr 27, 2018
@Fryguy Fryguy self-assigned this Apr 27, 2018
@Fryguy
Copy link
Member

Fryguy commented Apr 27, 2018

@simaishi This PR is a bug fix for a migration, so needs to be backported to gaprindashvili.

@bdunne bdunne deleted the nil_update_repo_name branch April 27, 2018 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants