Add configuration_script_sources.last_update_error #187
Conversation
|
@Glutexo I see that there is lot of related PRs to the BZ. Would you like to create GH issue for tracking it ? It is not clear what need to be merged first. |
|
Just pinging @Fryguy. Is this PR ok to be merged? There are other PRs that depend on this one. See ManageIQ/manageiq#17307 |
|
@Fryguy Hey, may I ask you for a review/merge of this PR? It’s required by ManageIQ/manageiq#17290 and through that by other PRs too. Thanks! |
| @@ -0,0 +1,5 @@ | |||
| class AddLastUpdateStdoutToConfigurationScriptSource < ActiveRecord::Migration[5.0] | |||
| def change | |||
| add_column :configuration_script_sources, :last_update_stdout, :text | |||
There was a problem hiding this comment.
@bdunne Aside from my naming questions in ManageIQ/manageiq#17290 (comment), does this even make sense on configuration_script_sources? I thought sources was the content of the configuration script. But content is not invocation, and I'd expect an "output" field on the "runtime invocation" model.
There was a problem hiding this comment.
See ManageIQ/manageiq#17290 (comment) maybe we should continue the conversation over there?
There was a problem hiding this comment.
We still store some data concerning the last update: status and timestamp. The only difference is that in Tower these are propagated to the project itself, so they are accessible even without explicitly asking for the last update resource.
Glutexo
force-pushed
the
add_configuration_script_source_last_update_stdout
branch
from
32059cc to
f085d3a
Compare
Add new last_update_error column to configuration_script_sources table. This allows to store last update stdout to display more information about why its refresh failed.
Glutexo
force-pushed
the
add_configuration_script_source_last_update_stdout
branch
from
f085d3a to
7a5c1de
Compare
|
@Fryguy Renamed to last_update_error. Ready to merge? |
|
Checked commit Glutexo@7a5c1de with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Fryguy
changed the title
Add new
last_update_stdoutcolumn toconfiguration_script_sourcestable. This allows to store last update stdout to display more information about why its refresh failed.Fetching and presenting this information is a workaround for cloning repositories from HTTPS servers with untrusted SSL certificates. Tower API does not offer an option to disable SSL check, so with the stdout user can at least see, why the cloning actually failed.
https://bugzilla.redhat.com/show_bug.cgi?id=1513616
Followed by adding the column to model: #17290 in
manageiq./cc @jameswnl for review