Set the switch types for VMware switches #180
Conversation
agrare
force-pushed
the
set_switch_types
branch
4 times, most recently
from
305f7ef to
ab49622
Compare
|
@Fryguy You ok with merging this one? |
|
|
||
| class Host < ActiveRecord::Base | ||
| self.inheritance_column = :_type_disabled | ||
| has_many :host_switches |
There was a problem hiding this comment.
You have to add :class => "UpdateSwitchTypes::HostSwitch" so that it resolves correctly. Frankly, I'm surprised this doesn't fail in specs.
There was a problem hiding this comment.
Wait, these relationships aren't used anywhere in this migration. If they're only here for testing I would remove them, as we try to keep models in tests down to the bare essentials. You can just query the table directly on the foreign_key column in the tests.
There was a problem hiding this comment.
Moved Host and HostSwitch over to the test
There was a problem hiding this comment.
Yeah idk I didn't need to set :class_name for running the tests or for running the migrations against a live db, just added it to be safe
| let(:host_stub) { migration_stub(:Host) } | ||
|
|
||
| migration_context :up do | ||
| it "migrates a series of representative rows" do |
There was a problem hiding this comment.
Do you have any tests for the non-nil switch type case? ( to show they aren't affected )
agrare
force-pushed
the
set_switch_types
branch
2 times, most recently
from
47acfef to
e2e649d
Compare
Update existing switches to set their types to either DistributedVirtualSwitch for shared switches or HostVirtualSwitch for non-shared switches.
|
Checked commit agrare@10edec6 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 db/migrate/20180316164826_update_switch_types.rb
|
Update existing switches to set their types to either
DistributedVirtualSwitch for shared switches or HostVirtualSwitch for
non-shared switches.
Depends: ManageIQ/manageiq-providers-vmware#212