Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecation warning for destroy_all #130

Merged
merged 1 commit into from
Nov 16, 2017
Merged

Remove deprecation warning for destroy_all #130

merged 1 commit into from
Nov 16, 2017

Conversation

Fryguy
Copy link
Member

@Fryguy Fryguy commented Nov 16, 2017

@carbonin Please review.

@Fryguy Fryguy added this to the Sprint 74 Ending Nov 27, 2017 milestone Nov 16, 2017
@miq-bot
Copy link
Member

miq-bot commented Nov 16, 2017

Checked commit Fryguy@e0ca986 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍰

carbonin
carbonin approved these changes Nov 16, 2017
View reviewed changes
Copy link
Member

@carbonin carbonin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gtanzillo gtanzillo merged commit 0f8e525 into ManageIQ:master Nov 16, 2017
@Fryguy Fryguy deleted the remove_deprecation branch November 16, 2017 22:32
@Fryguy Fryguy added the cleanup label Nov 16, 2017
simaishi pushed a commit that referenced this pull request Nov 17, 2017
@gtanzillo @simaishi
Merge pull request #130 from Fryguy/remove_deprecation
ecd0641 
Remove deprecation warning for destroy_all
(cherry picked from commit 0f8e525)
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit ecd0641593d137970b64ea61dc0cbb51b7e42743
Author: Gregg Tanzillo <[email protected]>
Date:   Thu Nov 16 17:32:47 2017 -0500

    Merge pull request #130 from Fryguy/remove_deprecation
    
    Remove deprecation warning for destroy_all
    (cherry picked from commit 0f8e52524acdeab602ca5c000fabd0d33ee3d835)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carbonin carbonin carbonin approved these changes

Assignees

@carbonin carbonin

Labels
cleanup gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Fryguy @miq-bot @simaishi @carbonin @gtanzillo