Remove the schema checker, schema.yml and associated rake tasks #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related manageiq PR ManageIQ/manageiq#16488 |
Version 2.0 and greater of pglogical doesn't require that the columns of a replicated table be in the same order on the source and destination databases. All of this was written to guard against and correct this situation so now it can be removed. ref: 2ndQuadrant/pglogical@88ff7ff Closes ManageIQ#88
carbonin
force-pushed
the
remove_replication_column_order_checks
branch
from
2e130f5 to
983c8e5
Compare
|
Checked commit carbonin@983c8e5 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 **
|
simaishi
pushed a commit
that referenced
this pull request
Nov 17, 2017
…_checks Remove the schema checker, schema.yml and associated rake tasks (cherry picked from commit 3b76dce)
|
Gaprindashvili backport details: |
|
Awesome! I also looked at the talk article and saw you already added an entry to say that the tooling and test weren't needed any longer. Nice. http://talk.manageiq.org/t/new-schema-specs-for-new-replication/1404 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 2.0 and greater of pglogical doesn't require that the columns of a replicated table be in the same order on the source and destination databases.
All of this was written to guard against and correct this situation so now it can be removed.
ref: 2ndQuadrant/pglogical@88ff7ff
Closes #88
@miq-bot add_label technical debt, test, gaprindashvili/yes
/cc @jrafanie ✂️ 🔥